Apache Cassandra > Index > HowToCommit
Added by Johan Oskarsson, last edited by Johan Oskarsson on Apr 15, 2009  (view change)

New committers

New committers are encouraged to first read Apache's generic committer documentation:

The first act of a new core committer is typically to add their name to the credits page. This requires changing the XML source in https://svn.apache.org/repos/asf/incubator/cassandra/site/author/src/documentation/content/xdocs/developers.xml. Once done, update the Cassandra website as described Documentation here.

Review

Committers should, as often as possible, attempt to review patches submitted by others. See the list of available patches. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews and believe it to be of sufficient quality and the unit tests pass, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected.

Reject

Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.

Commit

When you commit a patch, please:

  1. Include the Jira issue id in the commit message, along with a short description of the change and the name of the contributor if it is not you. Be sure to get the issue id right, as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see these).
  2. Resolve the issue as fixed, thanking the contributor. Always set the "Fix Version" at this point, but please only set a single fix version, the earliest release in which the change will appear.