Attendees
Agenda
Use of MINA Protect-I/O mode as default
Commits review
JIRA Review
Outstanding actions
| revision | committer | date | comment | review comments |
|---|---|---|---|---|
r659105  |
aidan | 2008-05-22 | QPID-1085 : If an error occurs creating a durable subscriber with a selector delete the queue that was created. |
0-10 : makes the client blow as the queue doesn;t exist. Also how is delete sent when channel should already be closed. Also why almost duplicated code for createDurableSubscription between 0-8 and 0-10. broker appears to be processing queue delete on a closed channel?! - Raise JIRA queue delete cannot be issued after failure because channel should be closed! |
| r659163 |
arnaudsimon | 2008-05-22 | QPID-1079 : Updated ...test.client tests for using QpidTestCase + move QpidTestCase in main so it is visible form systests |
Remove amqj.AutoCreateVMBroker Investigate if tests aren't working on trunk without this setting Remove VMTestCase? Remove all classes that were no longer referenced (VMBrokerSetup) RECEIVE_TIMEOUT : get rid of and use configurable timeout when available move kills to base case |
| r659262 |
arnaudsimon | 2008-05-22 | QPID-1079 : added junit dep to client as it's not included within all environments (for example on RHEL-4) |
Should move QpidTestCase into common base package; not in client. |
| r659271 |
rhs | 2008-05-22 | Made Range, RangeSet, and Session all use proper RFC1982 comparisons per QPID-861 . Also switched command ids from long -> int, and added a mutex to channel to prevent multi-frame commands from interle ... |
Use .intValue() not (int) (long) |
| r659631 |
rhs | 2008-05-23 | QPID-901 : Track and report session exceptions, modified generator validate values before trying to encode them. Also, moved createDurableSubscriber from AMQSession_0_10 -> AMQSession. |
|
| r659647 |
rhs | 2008-05-23 | QPID-947 : Switched over to using proper RFC 1982 serial numbers. |
|
| r659650 |
rhs | 2008-05-23 | QPID-1064 : only set the listeners to None after the thread has stopped |
|
| r659671 |
rhs | 2008-05-23 | QPID-947 : added codec and tests for array and list types |
|
| r659673 |
rhs | 2008-05-23 | QPID-947 : added test for nested lists |
Outstanding actions need to be carried forward in future
Use of Protect-I/O mode as default
Needs more testing before it is set as default in release, decision to be taken on list.
Review of Code Commits
| revision | committer | date | comment | |
|---|---|---|---|---|
| r659535 |
tross | 2008-05-23 | qpid-tool fixed to cleanly handle brokers with management disabled | |
| r659538 |
aconway | 2008-05-23 | qpid::SessionState: Added error checking for invalid frame sequences. client: Fix client crash on error during connection shutdown. | |
| r659631 |
rhs | 2008-05-23 | QPID-901 : Track and report session exceptions, modified generator validate values before trying to encode them. Also, moved createDurableSubscriber from AMQSession_0_10 -> AMQSession. |
|
| r659647 |
rhs | 2008-05-23 | QPID-947 : Switched over to using proper RFC 1982 serial numbers. |
|
| r659650 |
rhs | 2008-05-23 | QPID-1064 : only set the listeners to None after the thread has stopped |
|
| r659663 |
aconway | 2008-05-23 | Delete obsolete Channel class. | |
| r659671 |
rhs | 2008-05-23 | QPID-947 : added codec and tests for array and list types |
|
| r659673 |
rhs | 2008-05-23 | QPID-947 : added test for nested lists |
|
| r660173 |
aconway | 2008-05-26 | Fix compile error in examples. | |
| r660254 |
rajith | 2008-05-26 | I am applying the patch provided by Senaka attached to QPID-968 We need to get rid of the defaults that points to rhm. |
|
| r660258 |
aconway | 2008-05-26 | Changes to Session API: - Session is synchronous, no futures. - AsyncSession is async, returns futures. - Conversion functions sync(s) async(s) return a sync/async view of session s. - Connection ... | |
| r660265 |
aconway | 2008-05-26 | Corrected examples for new session API. | |
| r660302 |
aconway | 2008-05-26 | Speculative "fix" for solaris compile errors discussed on qpid-dev. | |
| r660304 |
aconway | 2008-05-26 | Removed BOOST_REQUIRE_EQUAL, not available in older boost.test. | |
| r660320 |
aconway | 2008-05-26 | Fixed intermittent leak of client::Connector thread. | |
| r660324 |
aconway | 2008-05-26 | Make help2man and doxygen dependencies optional. | |
| r660490 |
rgodfrey | 2008-05-27 | Refactoring updates (job queue changes, enqueue collections..) | |
| r660494 |
rgodfrey | 2008-05-27 | Missed one... | |
| r660546 |
gsim | 2008-05-27 | Added some comments to the various connection settings. | |
| r660562 |
aconway | 2008-05-27 | Additional API documentation around sync vs. async sessions. | |
| r660568 |
aconway | 2008-05-27 | Copy valgrind support files in a VPATH builds. | |
| r660616 |
aconway | 2008-05-27 | Generate code in $builddir to allow multiple VPATH builds. | |
| r660619 |
aconway | 2008-05-27 | VPATH fix | |
| r660625 |
aconway | 2008-05-27 | Use symbolic constants for message flow values. | |
| r660643 |
aconway | 2008-05-27 | Tighten up sync-correctness in SubscriptionManager & Dispatcher. Add a flush to SessionBase_0_10::sync() so it syncs in both directions. | |
| r660647 |
aconway | 2008-05-27 | Fixed error in RangeSet, caused compile failure on Solaris. | |
| r660715 |
aconway | 2008-05-27 | Removed obsolete src/qpid/client/SessionImpl.h .cpp | |
| r660886 |
gsim | 2008-05-28 | Fixes to binding of member functions as raised on qpid list by Manuel Teira. | |
| r660911 |
arnaudsimon | 2008-05-28 | QPID-1094 : Implement XA resource exception handling and add corresponding tests |
|
| r660922 |
arnaudsimon | 2008-05-28 | QPID-1097 : Those changes have been suggested by Lana |
Needs more detail, who is Lana? |
| r660924 |
gsim | 2008-05-28 | QPID-1095 : fixes to dtx error codes for latest spec changes. |
|
| r660952 |
gsim | 2008-05-28 | QPID-1095 : another error code correction |
|
| r660953 |
gsim | 2008-05-28 | QPID-1098 : correction to queue query when queue is not known |
|
| r660966 |
aidan | 2008-05-28 | QPID-1099 Add tests for publishing several messages transactionally and consuming them in an OnMessage handler |
|
| r660973 |
arnaudsimon | 2008-05-28 | QPID-1094 and QPID-1095 : Updated XaResource for handling wrong flag value, updated xa tests for using correct flag values, excluded forget test as the current 0.10 broker does not implement forget. |
|
| r660981 |
gsim | 2008-05-28 | Improve latency test tool to allow lower rates. | |
| r661000 |
gsim | 2008-05-28 | Updated some 'todo' comments with clearer text. | |
| r661267 |
arnaudsimon | 2008-05-29 | QPID-1094 : added finally close for cleaning potential indoubt tx |
|
| r661286 |
rgodfrey | 2008-05-29 | Avoid NPEs  |
|
| r661287 |
rgodfrey | 2008-05-29 | Deliver async per subscription; not queue | |
| r661296 |
rgodfrey | 2008-05-29 | tidy up | |
| r661302 |
gsim | 2008-05-29 | Only record frames for replay if timeout is non-zero. | |
| r661309 |
gsim | 2008-05-29 | Move AckPolicy impl from header to .cpp; ensure that completion is marked even when auto-acking is turned off. | |
| r661323 |
gsim | 2008-05-29 | Correct declarations to be the same as definitions. | |
| r661324 |
rgodfrey | 2008-05-29 | Temp fix out of order issue with async(sub) | |
| r661325 |
rgodfrey | 2008-05-29 | Made subscription sendLock straight lock, re-enabled per subscription async delivery | |
| r661326 |
rgodfrey | 2008-05-29 | Fix SubscriptionTestHelper | |
| r661395 |
rgodfrey | 2008-05-29 | Comments and changes from review | |
| r661405 |
rgodfrey | 2008-05-29 | fix browser behaviour on deliverAsync(sub) | |
| r661445 |
aconway | 2008-05-29 | Packaing error - SessionId.h | |
| r661455 |
cctrieloff | 2008-05-29 | Performnace fix, improves 6-8% on high core count machines. | |
| r661483 |
tross | 2008-05-29 | QPID-1100 crash when config file contains commented-out commands (patch from michael goulish) |
|
| r661561 |
rajith | 2008-05-30 | This check in is for QPID-1102 . IoHandler and IoSender uses the java.io classes for IO operations and have shown very good improvement in latency and memory usage over MINA. For certain tests with pub ... |
Should use configuration and be more configurable. Narrow catch Exception clause. |
| r661587 |
gsim | 2008-05-30 | Convert remaining cppunit tests to boost test framework to reduce dependencies. | |
| r661633 |
arnaudsimon | 2008-05-30 | QPID-754 : changed prop name |
Review of Recently Raised JIRAs
| Key | Component(s) | Affects Version/s | Summary | Status | Assignee | Reporter | Review Comments |
|---|---|---|---|---|---|---|---|
| QPID-1090 |
C++ Broker | M3 | (QPID-1090) Removed pid storage for daemon mode - rely on external mechanisms | In Progress | Ted Ross | Ted Ross | |
| QPID-1091 |
Java Tests | M3 | (QPID-1091) QpidTestCase does not clean up the InVM Broker after each test. | Open | Unassigned | Martin Ritchie | MR to raise Jira to clean message stores between test runs |
| QPID-1092 |
Java Client | M2, M2.1 | (QPID-1092) JMSObjectMessage.toBodyString corrupts the ByteBuffer if the data is not a String | Open | Unassigned | Martin Ritchie | MR to assign to M3 as well |
| QPID-1093 |
Java Broker | M2.1 | (QPID-1093) (Java Broker) Meta data not found when registering a consumer using a selectors | Open | Unassigned | Rob Godfrey | |
| QPID-1094 |
Java Client | M3 | (QPID-1094) xaResource does not correctly handle exceptions | Open | Arnaud Simon | Arnaud Simon | |
| QPID-1095 |
C++ Broker | M3 | (QPID-1095) dtx class does not fail with expected error codes | Closed | Gordon Sim | Arnaud Simon | |
| QPID-1096 |
C++ Broker | M3 | (QPID-1096) Exception codes for dtx need to be updated in line with final 0-10 spec | Open | Gordon Sim | Gordon Sim | |
| QPID-1097 |
Java Client | M3 | (QPID-1097) Need to improve 0.10 interface javadoc | Open | Arnaud Simon | Arnaud Simon | |
| QPID-1098 |
C++ Broker | M3 | (QPID-1098) Final 0-10 specification reqiures empty struct to be returned if queried queue is not found | Resolved | Gordon Sim | Gordon Sim | |
| QPID-1099 |
Dot Net Client | M3 | (QPID-1099) Add tests for checking transactional message consumption using OnMessage | Open | Aidan Skinner | Aidan Skinner | |
| QPID-1100 |
C++ Broker | M3 | (QPID-1100) crash when config file contains commented-out commands. | Open | Ted Ross | michael goulish | |
| QPID-1101 |
Java Broker | M2, M2.1 | (QPID-1101) DestWildExchange uses shallow copy of queues for routing, causing routing to fail if queueDeleted. | Open | Unassigned | Martin Ritchie | |
| QPID-1102 |
C++ Client | M3 | (QPID-1102) A new java.io based blocking transport for client | Open | Rajith Attapattu | Rajith Attapattu | Java client component, should be resolved. |
| QPID-1103 |
Java Tests | (QPID-1103) Add ability to provide a configuration file for broker start up in java test suite | Open | Martin Ritchie | Martin Ritchie | ||
| QPID-1104 |
Dot Net Client | M2.1 | (QPID-1104) (.Net) Allow acknowledgement of a single message | Open | Unassigned | Marnie McCormack | |
| QPID-1105 |
C++ Broker, C++ Client, Code Generator | M3 | (QPID-1105) Patches and additions to port to Windows | Open | Unassigned | Steve Huston | |
| QPID-1106 |
M3 | (QPID-1106) Make message acknowledgment synchronous | Open | Unassigned | Arnaud Simon | Needs component. |