This Confluence has been LDAP enabled, if you are an ASF Committer, please use your LDAP Credentials to login. Any problems file an INFRA jira ticket please.

Skip to end of metadata
Go to start of metadata

Committer Responsibilities 

Committers are more than contributors. While it's important for committers to maintain standing by committing code, their key role is to build and foster a healthy and active community. This means that committers should 

  • Review PRs in a timely and reliable fashion
    • They should also help to actively whittle down the PR backlog (e.g. we currently have more than 100 PRs, many of which are over 3 months old)
  • Answering questions (i.e. on the dev list, in PRs, in Jiras, etc...)
  • Taking on core changes/bugs/feature requests
    • Some changes are important enough that a committer needs to ensure it gets done. This is especially the case if one one from the community is taking it on.
  • Improving processes and tooling
  • Refactoring code, etc...


Commit Policy

The following commit policy passed by a vote 8(binding FOR) to 0 against on May 27, 2016 on the dev list:

Commits need a +1 vote from a committer who is not the author

 

Furthermore, do not +1 or merge a PR that regresses linting (e.g. Landscape.io) or does not pass 4/6 travis tests.


Style Guide

Before merging a PR, please make sure that it is compliant with the points from the Contributors' Guide, in particular:

  • The PR title references a JIRA issue [AIRFLOW-XXX], where XXX is the JIRA number, and contains a JIRA link in the PR description
  • Any new files have an Apache License header
  • All commits follow the 7 rules of good Git commits and reference a JIRA issue if appropriate



Apache Gitbox

To get access to the Apache Airflow Github, to comment on and merge Pull requests, you need to configure Apache Gitbox: https://gitbox.apache.org/



Adding New Committers/PMC Members to the Airflow Incubation Status Page

The goal of these instructions is to update http://incubator.apache.org/projects/airflow.html


  1. Check out the svn repo at https://svn.apache.org/repos/asf/incubator/public/trunk/content/projects
  2. Update {local_working_dir}/content/projects/airflow.xml
  3. svn commit -m "Adding xxx as committer/pmc member to apache airflow"
  4. Publish to the incubator website using https://cms.apache.org/incubator/publish
  5. Verify your change on http://incubator.apache.org/projects/airflow.html

The Incubator website is no longer managed via CMS. The website is built on Jenkins and the website builds daily for updates. Hence, you would be able to view the change at most by the next day. For more information visit Link 1 | Link 2 | Link 3


  • No labels

3 Comments

  1. A PR can be closed without committing it like so: https://mahout.apache.org/developers/github.html#closing-a-pr-without-committing-for-committers

    Here's an example that closed https://github.com/apache/incubator-airflow/pull/2440 :

    git commit --allow-empty -m "Closes apache/incubator-airflow#2440 *Already Merged*"

  2. From Bolke de Bruin:

    if you install https://github.com/github/hub you can pass it a PR URL as well making it really easy
    so basically git checkout master, and git am https://github.com/apache/incubator-airflow/pull/1485
    this will apply the contributor's commits to your master, retaining the author information
    then you can run git commit --amend to change it (reword the commit, add cosmetic fixes, etc.)
    and if you do that the author full remain the contributor, and you'll be added as a committer

  3. Useful guide for adding new committers/PMC members:

    https://reference.apache.org/pmc/acreq

    Whimsy's link for adding new users is here:

    https://whimsy.apache.org/roster/ppmc/airflow