This Confluence has been LDAP enabled, if you are an ASF Committer, please use your LDAP Credentials to login. Any problems file an INFRA jira ticket please.

Child pages
  • KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file
Skip to end of metadata
Go to start of metadata

Status

Current state: Under Discussion

Discussion thread: here

JIRA: here

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

Currently both ReassignPartitionsCommand and LogDirsCommand instantiates AdminClient using bootstrap.servers provided by the user. Since it does not take other ssl-related properties from user, these tools will not be able to talk to broker over SSL.

In order to solve this problem, these tools should allow users to provide property file containing arbitrary configs to be passed to AdminClient.


Public Interfaces

Add optional argument "command-config" to both kafka-reassign-partitions.sh and kafka-log-dirs.sh with the following specification

parser.accepts("command-config", "Property file containing configs to be passed to Admin Client.")
      .withRequiredArg
      .describedAs("command config property file")
      .ofType(classOf[String])


Proposed Changes

When "--command-config" is specified by user, the property file will be used to instantiate the AdminClient used by these tools. This is the same approach used by "--command-config" in ConfigCommand.

The bootstrap url specified by "--bootstrap-server" option will take precedence over the bootstrap.servers specified in the property file.



  • No labels