Page tree
Skip to end of metadata
Go to start of metadata

Based on comments from IPMC on Apache NetBeans (incubating) 9.0 Beta rc2:

...these are the items that need to be fixed for Apache NetBeans (incubating) 9.0 Beta to be released:

 QuoteDetailsRelated Issue
1

"Unexpected binary files in the source release (these contain compiled code)". (JM)

"Remove the binary zip files from the source release." (JA)

./lib.terminalemulator/examples/lib.richexecution/process_start-linux-intel.zip
./lib.terminalemulator/examples/lib.richexecution/process_start-mac-intel.zip
./lib.terminalemulator/examples/lib.richexecution/process_start-solaris-intel.zip
./lib.terminalemulator/examples/lib.richexecution/process_start-solaris-sparc.zip

NETBEANS-303 - Remove binary ZIPs from lib.terminalemulator/examples Resolved

 

2"Every issue raised by JM represented in JIRA somewhere." (JA)That is what this page aims to provide. NETBEANS-304 - Every issue raised by IPMC in 9.0 Beta rc2 vote to be in JIRA Resolved
3

"There’s a number of file that are missing ASF headers, including 700 odd java files" (JM)

"Specific call outs in the README about test data licensing not be Apache

license." (JA)

These are test data (all in test/*/data), they are (at worst) pseudo code and are really nothing more than test data, which would cause tests to fail if they were licensed and hence fall under this Apache exception in terms of license headers not being required:

https://www.apache.org/legal/src-headers.html#faq-exceptions

On the other hand, this looks like Java source code, whether used for test purposes or not, and we need to decide whether they should/should not be licensed:

https://github.com/apache/incubator-netbeans/blob/master/java.hints/test/unit/data/org/netbeans/test/java/hints/AddCast1.java

 

NETBEANS-306 - Java source files as test data: need licensing or not? Resolved
4

"LICENSE is missing licenses for these CDDL, EPL, and the sun public licensed files, however CDDL, EPL and the sun public license are in Category B and not allowed is source form in a release." (JM)

"Specific call outs somewhere that the XSDs, ENTs, etc are derived from other locations." (JA)

xml.jaxb/src/org/netbeans/modules/xml/jaxb/resources/eclipselink_oxm_2_3.xsd
maven.coverage/src/org/netbeans/modules/maven/coverage/jacoco-1.0.dtd
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_2_0.xsd
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_2_1.xsd
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_2_0.xsd
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_2_1.xsd

j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_1_0.xsd
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_1_0.xsd
websvc.saas.api/src/org/netbeans/modules/websvc/saas/model/wadl20061109.xsd
test/unit/src/org/netbeans/modules/editor/settings/storage/compatibility/p1/SFS-Editors-Folder.zip/

diff/test/unit/src/org/netbeans/modules/diff/builtin/provider/DiffTestFile1a.txt diff/test/unit/src/org/netbeans/modules/diff/builtin/provider/DiffTestFile1b.txt

NETBEANS-310 - EPL licensed files to be resolved Resolved

NETBEANS-311 - CDDL/GPL licensed files to be resolved Resolved

NETBEANS-307 - Sun licensed files to be relicensed to Apache Closed

...and these need to be fixed at some point after Apache NetBeans (incubating) 9.0 Beta but before becoming a top level project:

 QuoteNotesRelated Issue
1"Several (not dual license) GPL license files exist in the source release. Does this software include GPL or depend on any GPL licensed software?" (JM)

For instance:
nbbuild/licenses/LGPL-2.1
apisupport.installer/src/org/netbeans/modules/apisupport/installer/resources/licenses/GPL

NETBEANS-305 - Several (not dual license) GPL license files exist Open
2"LICENSE is missing licenses for this MIT licensed file (which also includes MIT licensed normalize.css)." (JM)css.model/test/unit/data/testfiles/bootstrap.css

NETBEANS-313 - Resolve MIT licensed file Resolved

3"LICENSE is missing licenses for this IOS file (and about a dozen other files)." (JM)

html.editor/src/org/netbeans/modules/html/editor/resources/DTDs/4_0/HTMLlat1.ent

NETBEANS-314 - Correct attribution for w3c licensed files Resolved
4"LICENSE is missing licenses for this W3C file (and about a dozen others)." (JM)src/org/netbeans/modules/xml/catalog/resources/Transform.xsd NETBEANS-316 - Resolve licensing of Transform.xsd and other W3C files Resolved
5"How is this file licensed?" (JM)welcome/resources/rss-0_91.dtd NETBEANS-315 - Resolve licensing of welcome/resources/rss-0_91.dtd Resolved
6"This patch file seems to be removing a GPL/CDDL/MIT header." (JM)

css.lib/src/org/netbeans/modules/css/lib/antlrv4.patch

html.validation/external/validator.patch

NETBEANS-312 - Patch files removing headers Open
7"There are a large number of icons in the release do know the ip provenance of them and how they are licensed?" (JM)Remove the rat exclusion for the images, run rat again, and we'll have a long list of these to examine. All comments related to this, please add them as comments to the related issue. NETBEANS-309 - IP provenance of icons in Apache NetBeans Open
8"There also seems to be a number of stock photos in the release. How are they licensed? Do you have permission to use or distribute them?" (JM)

javafx2.samples/DisplayShelf/src/displayshelf/animalX.jpg
javafx2.samples/Fireworks/src/Fireworks/sf.jpg
javafx2.samples/PuzzlePieces/src/puzzlepieces/PuzzlePieces-picture.jpg

NETBEANS-308 - Licensing of javafx2.samples stock photos Open
9"I glanced at the binary LICENSE and NOTICE of the binary and I think there's too much information in there.

- There is no need to repeat the Apache license text several times
- Only 3rd party software that is bundled in the source release needs to be mention in LICENSE and NOTICE. Is everything mentioned really bundled?
- NOTICE seems to contain too much information
- For long licenses it best to use a pointer the the full text of the license rather than include the full text" (JM)

  NETBEANS-317 - Too much info in binary LICENSE and NOTICE Open
10Move Rat exclusion definitions to a separate file, so the history and development of the exclusions can be more easily tracked.  NETBEANS-318 - Move RAT exclusion definitions to a separate file Resolved
11Remove compiled souec code1 ./autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed-twice.jar
2 ./autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed.jar
3 ./classfile/test/unit/src/org/netbeans/modules/classfile/datafiles/WithLambda.classx
4 ./classfile/test/unit/src/regression/datafiles/left-square.class
5 ./classfile/test/unit/src/regression/datafiles/SwitchData.class
6 ./classfile/test/unit/src/regression/datafiles/test91098.class
7 ./nbi/engine/src/org/netbeans/installer/utils/applications/TestJDK.class
NETBEANS-410 - Remove compiled source code Open
12Licensing of wav file in JavaFX sample

/javafx2.samples/Xylophone/src/xylophone/Note?.wav

NETBEANS-411 - Licensing of wav file in JavaFX sample Open

 


 

 

 
 QuoteNotes 
 

Netbeans jars are missing LICENSE and NOTICE file in META_INF. Note that this may vary on a jar by jar basis.

work in progress 
 

./extide/ant/etc/ant-bootstrap.jar (and other ant jars)

- see LICENSE at it mentions SAX2 and that may be missing from LICENSE

  
 

./harness/antlib/bindex-2.2.jar

- has odd NOTICE that may impact NOTICE file. Looking at it I think the notice bit should be included and the rest may affect LICENSE.

  
 

./ide/modules/com-googlecode-javaewah-JavaEWAH.jar

- has no notice but copyright has been incorrectly add to license you may want to include that in NOTICE as if it was in a NOTICE file or do nothing.

  
 

./ide/modules/com-jcraft-jzlib.jar

- missing from LICENSE

  
 

./ide/modules/ext/commons-compress-1.8.1.jar

- I see the public domain “notice” has been copied from the notice file. IMO this should be in notice but in license but is an upstream issue.

  
 

./ide/modules/ext/commons-net-3.6.jar

- probably no need to include this in NOTICE as you’re done

  
 

./ide/modules/ext/freemarker-2.3.19.jar

- no need for line (Visigoth Software) in NOTICE having it in license is enough IMO

  
 

./ide/modules/ext/ini4j-0.5.1.jar

- missing form NOTICE

  
 

./ide/modules/ext/jaxb/jaxb-xjc-2.2.5-2.jar

- contains org.kohsuke.rngom MIT licensed missing from LICENSE

  
 

./ide/modules/ext/jaxb/jaxb1-impl-2.2.5-2.jar

- also contains 3rd party code not mentioned in LICENSE

  
 

./ide/modules/ext/lucene-core-3.5.0.jar

- thesis where the bulk of you NOTICE info come from and why I thought something was up. Again

it’s an upstream issue just about all of this information should be in LICENSE not NOTICE,

but as the upstream project NOTICE file has this issue including it all is valid.

  
 

./ide/modules/ext/resolver-1.2.jar

- missing from NOTICE file

  
 

./ide/modules/ext/servlet-2.2.jar

- this seems to be CDDL not Apache 1.1? Not 100% sure here.

  
 

./ide/modules/ext/smackx.jar

- includes BSD licensed JZlib missing from LICENSE

  
 

./ide/modules/ext/webserver.jar

- I assume this is tomcat? if so it has a NOTICE file and should be included in NOTICE. Pity

there no NOTICE file in the jar.

  
 

./ide/modules/ext/winp-1.14-patched.jar

- LICENSE is missing this MIT licensed

  
 

./ide/modules/ext/xerces-2.8.0.jar

- has NOTICE that would effect NOTICE file

  
 

./ide/modules/org-apache-commons-codec.jar

- has NOTICE that would effect NOTICE file

  
 

./ide/modules/org-apache-commons-lang.jar

- probably has NOTICE that would effect NOTICE file

  
 

./ide/modules/org-openidex-util.jar

- CDDL licensed missing in LICENSE

A NetBeans jar. 
 

java/maven/boot/plexus-classworlds-2.5.2.jar

- is not Apache licensed

jlahoda: not sure there's a problem: the jar is distributed by Apache Maven without a special license, and what appears to be the homepage: https://codehaus-plexus.github.io/plexus-classworlds/license.html says Apache License, Version 2.0 
 

./java/maven/lib/aether-api-1.0.2.v20150114.jar  

./java/maven/lib/aether-connector-basic-1.0.2.v20150114.jar

./java/maven/lib/aether-impl-1.0.2.v20150114.jar

./java/maven/lib/aether-spi-1.0.2.v20150114.jar

./java/maven/lib/aether-transport-wagon-1.0.2.v20150114.jar

./java/maven/lib/aether-util-1.0.2.v20150114.jar

- are EPL license not Apache licensed

work in progress 
 

./java/maven/lib/commons-lang3-3.4.jar

- probably has NOTICE that would effect NOTICE file

  
 

java/maven/lib/jsoup-1.7.2.jar     

- is MIT licensed not Apache licensed

work in progress 
 

java/maven/lib/jsr250-api-1.0.jar

- is CDDL licensed not Apache licensed

work in progress 
 

./java/maven/lib/org.eclipse.sisu.inject-0.3.2.jar

./java/maven/lib/org.eclipse.sisu.plexus-0.3.2.jar

- are EPL licensed not Apache licensed

work in progress 
 

./java/maven/lib/plexus-cipher-1.7.jar

- has a NOTICE file that would effect NOTICE

  
 

./java/maven/lib/slf4j-simple-1.7.5.jar

./java/maven/lib/slf4j-api-1.7.5.jar

- are MIT licensed not Apache licensed

work in progress 
 

./java/modules/ext/cglib-2.2.jar

- has an incorrect NOTICE file (copy/paste error I assume) and if fixed may effect the NOTICE file

  
 

java/modules/ext/jaxws22/FastInfoset.jar  

- is under an Apache license not a CDDL one

  
 

./java/modules/ext/jaxws22/stax2-api.jar

- is under a BSD license not a CDDL one

  
 

./java/modules/ext/jaxws22/woodstox-core-asl.jar

- is under an Apache 2.0 license not a CDDL one and has a NOTICE file that effect NOTICE (although none of it’s content mean anything IMO)

  
 

./java/modules/ext/maven/indexer-core-6.0-SNAPSHOT-patched.jar

- is may not be possible to release with a snapshot jar I not sure re that. It as ASF project and the code has not been released by it’s PMC.

  
 

./java/modules/ext/maven/jdom-1.0.jar

- is BSD Style rather than Apache licensed

  
 

./java/modules/ext/spring-3.0/spring-context-3.2.7.RELEASE.jar

./java/modules/ext/spring-3.0/spring-context-support-3.2.7.RELEASE.jar

(and other spring jars)

- has a NOTICE file that would effect the NOTICE file

  
 

./platform/modules/ext/org.apache.felix.main-4.2.1.jar

- has a NOTICE file that would effect the NOTICE file

  
 

platform/modules/ext/org.eclipse.osgi_3.9.1.v20140110-1610.jar

- I’m not sure if the OSGi license is compatible with the Apache one. It’s not listed in Category A/B/X you may need to ask on legal discuss. It may be under EPL but not 100% sure.

LEGAL-361 - Can Apache NetBeans (incubating) use adjusted org.eclipse.osgi_3.9.1.v20140110-1610.jar Open  
 

./platform/modules/ext/testng-6.8.1-dist.jar

- contains apache licensed jcommander and MIT licensed jquery

- jcommander has a notice that would effect NOTICE

  
 

./platform/modules/net-java-html-boot-fx.jar

./platform/modules/net-java-html-boot-script.jar

./platform/modules/net-java-html-boot.jar

./platform/modules/net-java-html-geo.jar

./platform/modules/net-java-html-sound.jar

./platform/modules/net-java-html.jar

- have NOTICE files that would effect the NOTICE file

- a couple have DISCLAIMER is that’s right?

- are the copyright lines in NOTICE correct here?

Fixed in the HTML/Java repo as  6363e49ea72 & ready for next release of HTML/Java API.

 

 
 

./platform/modules/org-openide-compat.jar

./platform/modules/org-openide-dialogs.jar

(and a few others similarly named)

- are missing from LICENSE

NetBeans jars. 
 ./libs.git/test/unit/data/private_keyIt would be good to rename this file to something like "testing_key" to clarify that it's not in there by mistake. NETBEANS-283 - private_key in libs.git module should be renamed Open  

 

 

  • No labels

2 Comments

  1. One minor thing that I also suggested on the Incubator general list is to move the RAT exclusions definitions to their own file which contains nothing else. This will make them and especially their evolution easier to track.

  2. Great, yes, will make an issue for this too.