Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Initial bulletpoints in Criteria For Acceptance

...

How To Submit Changes For Review


Criteria For Acceptance

This section defines what sorts of things committers will examine and verify before allowing changes into NuttX.

This is documented here for three reasons:

  • To make it easier for NuttX participants to get their changes accepted.
  • As a checklist of things for NuttX committers to look for when reviewing a potential change.
  • As a specification of checks that can be automated over time, eventually saving everyone a lot of work!

First, there are the universal requirements that apply to all parts of NuttX:

  • INVIOLABLES, the overarching principles of this project
  • Coding standard: nx-style
  • Clean architecture
  • POSIX compliance
  • Successful build

In addition to the universal requirements, various parts of the NuttX system have their own specific needs:

  • The build system
  • Tools
  • Architectural support
  • Board support
  • Scheduler
  • System calls
  • Libraries

TODO: This section is incomplete! Please leave the bulletpoints above as-is, and develop the text in new subheadings below.

Reference For Committers