Versions Compared

Old Version 14

changes.mady.by.user Sravya Tirukkovalur

Saved on

compared with

New Version 15

changes.mady.by.user Sravya Tirukkovalur

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Submitting your patch for review:
    1. To submit a patch, attach the patch file to the JIRA and change the status of the JIRA to "Patch Available".
    2. If the change is non-trivial, please also post it for review on the Review Board. Use the Repository "sentry" on Review Board.
    3. Use can use rbtools, a command line tool for Review board to speed up the process of submitting the review requests

      1. Download rbt

      2. Setup your ~/.reviewboardrc with the following content

        Code Block
        REVIEWBOARD_URL = "https://reviews.apache.org/"
REPOSITORY = 'Sentry'
TARGET_GROUPS = 'sentry'

      3. You can setup your username password like 

        Code Block
        rbt setup-repo --username=xx --password=xx

      4. Post the review: Commit your changes to your local repo and do:

        Code Block
        rbt post -g


      5. Fill in the Summary in the webpage and post it.

      6. Updating your review: append your changes the original commit and

        Code Block
        rbt post -g -r=<review#>
    4. Link the JIRA to the Review Board review and vise versa. JIRA has a feature you can use for this by going to More Actions > Link > Web Link when logged into JIRA.

...