...
- Submitting your patch for review:
- To submit a patch, attach the patch file to the JIRA and change the status of the JIRA to "Patch Available".
- If the change is non-trivial, please also post it for review on the Review Board. Use the Repository "sentry" on Review Board.
- Use can use rbtools, a command line tool for Review board to speed up the process of submitting the review requests
Download rbt
Setup your ~/.reviewboardrc with the following content
Code Block REVIEWBOARD_URL = "https://reviews.apache.org/" REPOSITORY = 'Sentry' TARGET_GROUPS = 'sentry'
You can setup your username password like
Code Block rbt setup-repo --username=xx --password=xx
Post the review: Commit your changes to your local repo and do:
Code Block rbt post -g
- Fill in the Summary in the webpage and post it.
Updating your review: append your changes the original commit and
Code Block rbt post -g -r=<review#>
- Link the JIRA to the Review Board review and vise versa. JIRA has a feature you can use for this by going to More Actions > Link > Web Link when logged into JIRA.
...