Warning | ||
---|---|---|
| ||
This page is out of date, use Review Board instead. |
This page explains how to use Phabricator for code review of contributions to Apache Hive.
Table of Contents |
---|
Setup
- Visit https://reviews.facebook.net and connect your existing github or Facebook account there.
- The Phabricator command-line tool arc requires a PHP interpreter available on your development machine. If you can run the command php --version, you already have it. If not, google for "php command line" to see how to install it for your system.
- Next, install arc. If you follow the Arcanist Quick Start guide, only the first section ("Install Arcanist") is applicable.
- Run ant arc-setup to install an extra module needed for JIRA integration. (This ant target was added with the commit of HIVE-2486.)
- In your Hive checkout (either git or svn), run arc install-certificate and follow the instructions given.
...
1. If you run into an error like the following on arc:
Code Block |
---|
libphutil v1 libraries are no longer supported
|
git checkout this particular tag in your libphutil repository:
Code Block |
---|
git checkout 870bcc76434410344d27a3fa4604ac96200bf7f6
|
2. If you run into an error like this with Arcanist:
Code Block |
---|
Call to undefined method ArcanistGitAPI parseRelativeLocalCommit()
OR
Failed to load symbol ...
|
Checkout this tag for arcanist:
Code Block |
---|
git checkout 6f6fde84cc530c2b51f095d9636b9e15301519a1
|