...
cat ~/.ssh/id_\{r or d\}sa.pub
It's reported that RSA keys are denied in new OSes like Ubuntu 22.04 and MacOS 14 (Sonoma). Try other key types like edcsa or ed25519, e.g. try one of these
Code Block |
---|
ssh-keygen -t edcsa -b521
ssh-keygen -t ed25519 -b 4096 |
While you're in the settings page, please make sure to update your profile with your name, and your e-mail address!
...
To set up Gerrit as a git remote for your Impala repository, do the following:
...
, do the following:
Code Block |
---|
cd ${IMPALA_HOME}
git remote add asf-gerrit ssh://<your-github-username>@gerrit.cloudera.org:29418/Impala-ASF |
If using HTTP to connect to Gerrit, use the following command to add the Gerrit remote is also works:
Code Block |
---|
git remote add asf-gerrit |
...
http://<your-github-username>@gerrit.cloudera.org:8080/a/Impala-ASF |
Pay attention, when using HTTP to push/pull code, we need to input username/password. Do not use login account directly, we should get username/password from "Settings→HTTP Password" instead.
Sending a patch for review
...
If your commit touches files both in and out of the docs/ folder, run https://jenkins.impala.io/job/gerrit-verify-dryrun/build?delay=0sec first, following the directions above. Once it succeeds, run https://jenkins.impala.io/job/gerrit-docs-submit/build?delay=0sec.
Tip |
---|
Verifying and cherry-picking a patch can be simplified with a bookmarklet. Here is how to do that in Chrome:
By changing the javascript URL, you can also make a bookmarklet for the docs Jenkins job. |
When Jenkins has completed successfully, your change is in the master gerrit repo, but not yet in the official Apache repo. Apache does not allow non-sentient robots like Jenkins to submit patches. To get your patch to the official Apache repo, a committer needs to push the commit to the Apache git repository, by running:
...
Code Block |
---|
bin/push_to_asf.py |
push_to_asf.py checks the latest commits in gerrit and checks if they are in the Apache git repo. If some are not in the Apache git repo yet, it will ask you if you want to update the Apache git repo with the missing commits found in the Gerrit repo. It does not check what your local state is at all. It only compares remote Gerrit with the remote Apache repo. Keep in mind that if you are a committer, it will allow you to commit any change authored by anyone that has passed the Jenkins cherry-picking described above.
...