Ambari use uses ReviewBoard for code reviews.
...
You may need to create a ReviewBoard login. Once you login add yourself to the "Ambari" group.
To submit a patch for review
- Click on "New Review Request"
- Select "ambari" from the drop-down and upload a diff file
- Go to the next page
- Add a summary
- Names of two reviewers (only one +1 is necessary for commit)
- Select ambari as the group
- Type in the Ambari JIRA id
- Add description of the fix
- Add a link to the ReviewBoard URL to the JIRA
- [if applicable] Fill the optional fields as needed.
- [if applicable] Add the unit test summary to the request
- Publish the review
- After the review is marked "Ship It" you can optionally attach the final patch to the JIRA.
For reviewers
Reviewers, after you are satisfied with the patch, mark "Ship It" through the ReviewBoard as well as add a "+1" to the JIRA.