...
Commit the patch: If the patch meets review expectations and is well tested, it can be committed to the source control. Make sure that the patch applies cleanly to the latest revision and if not, request the patch be rebased accordingly. Once ready for commit, the commit message should have the following format:
if contributor is not you:
Code Block Sentry-XXX. Brief description of the problem. (Contributor's Name via Committer's Name)
if contributor is you:
Code Block Sentry-XXX. Brief description of the problem. (Committer's Name, reviewed by Reviewer's Name>)
- Mark the JIRA resolved: After the patch has been committed, you should mark the JIRA resolved and ensure that it's
fixVersion
is set to the next release version number. Make sure to thank the contributor in the comment you add while marking the JIRA resolved.
...