...
Code Block | ||
---|---|---|
| ||
# Clone the Apache repository. git clone https://git-wip-us.apache.org/repos/asf/incubator-hawq.git # Fork the apache github mirror incubator-hawq repo (https://github.com/apache/incubator-hawq). # Assume your own forked repo is: https://github.com/changleicn/incubator-hawq # This step can be done via Github web page. # Add your own forked github repo as “myfork” (used only for code review purpose) git remote add myfork https://github.com/changleicn/incubator-hawq # Merge the update of the upstream into your local master git checkout master && git pull origin master # Create a feature branch “feature-awesome” to work on git checkout -b feature-awesome master # Make changes and commit to local. Please format commit message as follows and feel free to add additional comments. # <jira ticket number>. <Commit Message> # Example: HAWQ-1002. Add awesome feature git commit -a -m "HAWQ-1002. Add awesome feature" # Push it to your github repo for code review git push --set-upstream myfork feature-awesome |
Now you can go to your own github fork to create pull requests on github for code review (https://github.com/changleicn/incubator-hawq). Choose the master branch of https://github.com/apache/incubator-hawq as the base for code review.
Code review
We expect that pull requests which have been submitted on github will be reviewed by committers, but will be visible to the community for comments as well. Contributors should learn the code review criteria in order to make the changes accepted.
Code review criteria
Features should have a lot of potential use cases and benefit a lot of users
- Fixes should fix the root cause of the problem
- Easily tested and have tests associated with the commits
- Changes have been discussed on JIRA and have a JIRA linked to your change(Pull Request)
- Code follows the coding conventions
- Do not introduce potential performance regressions
...