This Confluence has been LDAP enabled, if you are an ASF Committer, please use your LDAP Credentials to login. Any problems file an INFRA jira ticket please.

Page tree

Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: The "core" team is an ancient artifact from before the move to ASF

...

Except for the very smallest items, it’s a very good idea to discuss your intended approach either on the JIRA or on the dev@impala.apache.org mailing list. You are much more likely to have your patch reviewed and committed if you’ve already got buy-in from the core Impala team community before you start.

We may sometimes decide not to accept a proposed feature or bugfix. This does not mean we do not value your contribution, but more likely that we feel that it does not align with the goals of the project or it is not the right time.

...

Before getting started, you'll want to get your development environment set up. Read bin/bootstrap_development.sh to get going. You can also take a look at Docker for Impala DevelopersImpala Development Environment inside Docker.

Now start coding! As you are writing your patch, please keep the following things in mind:

...

When you have a patch that you consider ready for submission, submit it to our code review tool called Gerrit (see Using Gerrit to submit and review patches for details). You’ll see an e-mail go out to the dev@impala.apache.org list.

As time permits, someone from the core team After that, other community members will review your patch. You will likely need to submit an updated patch with some changes - reply to all the comments in Gerrit at the same time (mark as ‘Done’ those suggestions that you’ve taken without further comment). This process can go back and forth for a while - please don’t be discouraged, you’ll see it happens with all patches!

...

Once a patch is considered ready to go in, the reviewer a committer will give it the ‘+2’ mark in Gerrit, and will run the submission testing job.

If the testing job completes successfully, Gerrit will automatically submit the patch to Impala’s Github repository. Congratulations! You are now a contributor to Impala

...