Versions Compared


  • This line was added.
  • This line was removed.
  • Formatting was changed.


  • Migration plan :

    • Currently the code version is 0.10.1, message.format.version = 0.10.1, IBP = 0.10.1.
    • Create internal ApiVersion 0.10.2-IV0 which uses ProduceRequest V3 (magic byte = 2) and FetchRequest V3 (magic byte =2).
    • We first upgrade the code to support ApiVersion 0.10.2-IV0 with a rolling upgrade.
    • Do a rolling bounce and set the IBP = 0.10.2
    • Upgrade clients to start producing and consuming using ProduceRequest V3 (magic byte = 2) and FetchRequest V3 (magic byte =2).
      • At this point if the broker receives ProduceRequest V3 from producer with the tombstone bit set in the message, it will down convert it to set it to null. ProduceRequest V2 will work as it does today.
      • At this point if the broker receives FetchRequest V2 from consumer, we will not loose zero copy because the message is down converted. If the broker receives FetchRequest V3, it will still work as the consumer will be able to understand the tombstone bit.
    • When all the clients have upgraded, bump up the message.format.version to 0.10.2 on the broker. We should be careful here to see that almost all consumers are upgraded since at this point if broker receives a FetchRequest V2, we might loose zero copy on the broker.
      • To note on a downgrade for an non-upgraded consumer, the downgrade would make the value null for a tombstone message.
    • From log compaction point of view :
      • If the magic byte on message is 0, the broker should use the null value for log compaction.
      • If the magic byte on message is 1, the broker should use the null value for log compaction.
      • If the magic byte on message is 2, the broker should use the tombstone bit for log compaction.
    • NOTE : With the new version of producer client using ProduceRequest V3 (magic byte = 2), a non tombstone (tombstone bit not set) and null value should not be allowed as the older version of consumer using FetchRequest V2 will think of this as a tombstone when its actually not.
  • Client Compatibility:
    • If simply upgrading client, but no changes to code/flow (e.g. still sending null tombstones via existing constructors), we do not expect any app changes needed.
    • Producer
      • A new constructors for ProducerRecord will add an extra parameter tombstone: 
      • The old constructors for ProducerRecord without this parameter will be kept but updated so that their default behaviour if setting null value will be the tombstone will be set to true to keep existing behaviour.
    • Consumer
      • The ConsumerRecord will expose a new method isTombstone will be exposed
      • Existing flows that use null tombstones and continue to do so will not be affected as the value for a tombstone will still be null
        • As such simply upgrading clients and not the flow behaviour there will be node change needed.
        • It is recommended that their logic is updated to use the isTombstone for clean-ness.
      • New/Amended flows created where a producer may send non-null tombstones, the new consumer code will need to use isTombstone instead of relying on null value.

Rejected Alternatives

Do nothing KIP-82 would remove the immediate issue.