View Source

The following is a list of changes made by Oracle prior to the donation. (only donation #1 here). The changes were done because an amount of cleanup was required, most importantly some files in the NetBeans Mercurial repo couldn't be part of the donation as they weren't belonging to Oracle. However, just because a file could not legally be part of the donation doesn't mean that Apache NetBeans cannot include that same file (with proper attribution, license review, etc, of course).

Most of the donation changes cause runtime errors and/or change in functionality, rather than build time problems. If the problems surfaced at build time we would probably already have found them. Therefore, we need to review each change individually.

How to help

You can help by reviewing one or more changesets in the "Donation changes" table below.

Start by putting your Apache id next to the changeset.
Review what was done in the changeset. Is it something which requires action? For example files which were removed may need to be re-instated or replacement files found. Removal of files from the test tree is less serious than removal of files from the src tree.
If you find that an action is needed then log an issue for it in JIRA and tag it with label donation-fixes. If you feel up to it then you may also create a PR to go with the JIRA issue but that is not required right now. Put the JIRA issue number in the comments column.
Put "Done" in the status column when the changeset has been fully reviewed. (doesn't necessarily mean that a linked JIRA issues has been closed, it just means the review is completed)

Donation changes

Changeset	Who (Apache id)	Status	Comments
changeset Reema <Reema@netbeans.org> [Thu, 08 Jun 2017 02:25:25 -0700] rev 315963 removed Piped*Stream.java	lbruun jlahoda	Done	lbruun: JDK source is not part of the donation. Therefore these files had to be removed. But don't see why they cannot be included in Apache NetBeans with proper attribution, license header, etc. ? jlahoda: AFAIK: problematic to include these, as neither BCL nor GPL can be included (see: https://www.apache.org/legal/resolved.html#category-x). Luckily, AFAIK, these files are not really needed. lbruun: Understood. Let's just leave it at that. Conclusion: No action required. If it turns out that these files are indeed needed then we'll deal with it a the time, eg create our own PipedStream or something like that.
changeset Reema <Reema@netbeans.org> [Thu, 08 Jun 2017 01:04:10 -0700] rev 315962 removed lib.profiler test jars	matthiasblaesing	Done	Opened
changeset Reema <Reema@netbeans.org> [Wed, 07 Jun 2017 22:50:27 -0700] rev 315960 Removed test jar files	matthiasblaesing	Done	Minor impact - affected: ant.freeform - no impact (unittests work) lib.profiler - no impact mercurial - small impact (qatests reference the removed jar, but fix is trivial (remove reference)) subversion - small impact (qatests reference the removed jar, but fix is trivial (remove reference)) parsing.api - no impact (untitests work) parsing.nb - needs fixing parsing.indexing -
changeset Arusinha <arusinha@netbeans.org> [Wed, 07 Jun 2017 22:46:57 -0700] rev 315959 Apache Donation leftovers	matthiasblaesing	Done	xml.xdm: Unittests were "fixed" by disabling them, as it is only a subset of the tests, no issue was opened xml.text: All unittests pass, removed file is not referenced xml.schema.model: All unittests pass (one fails because it is locale dependend) git/lib.profiler/performance: functional tests seem to be broken and need more attention, but not (just) because of this removal
changeset Jan Lahoda <jlahoda@netbeans.org> [Tue, 06 Jun 2017 21:28:14 +0200] rev 315957 Commenting out references to deleted files.			Partly fixed: PR241 re-instates the layer link to `rss-0_91.dtd`.
changeset Reema <Reema@netbeans.org> [Tue, 06 Jun 2017 03:55:00 -0700] rev 315956 removed 3rd party files under xml.catalog	matthiasblaesing	Done	Files in xml.catalog were readded in bce3d24789daaccfd243837e91c9d48685ccda66, bootstrap.css was readded in 078dfb768bcd595f80698da2a2425d24be2a355f.
changeset Arusinha <arusinha@netbeans.org> [Fri, 02 Jun 2017 05:04:25 -0700] rev 315954 Corrected licenses for uploaded external zip file	matthiasblaesing	Done	License changes - no functional changes
changeset Arusinha <arusinha@netbeans.org> [Fri, 02 Jun 2017 03:20:00 -0700] rev 315952 deleted files from nbi/engine
changeset Reema <Reema@netbeans.org> [Fri, 02 Jun 2017 02:06:41 -0700] rev 315950 removed redundant license txt files	lbruun	Done	No action required. Will be fixed in module review process.
changeset Arusinha <arusinha@netbeans.org> [Fri, 02 Jun 2017 00:09:43 -0700] rev 315949 deleted files from applemenu module	jlahoda	Done.	AFAIK resolved as part of review changes to the applemenu module.
changeset Arusinha <arusinha@netbeans.org> [Fri, 02 Jun 2017 00:02:10 -0700] rev 315947 deleted files from applemenu module	jlahoda	Done.	AFAIK resolved as part of review changes to the applemenu module.
changeset Reema <Reema@netbeans.org> [Thu, 01 Jun 2017 03:20:25 -0700] rev 315938 more 3rd party files from .ide	matthiasblaesing	Done	removed XSDs were already readded
changeset Reema <Reema@netbeans.org> [Thu, 01 Jun 2017 01:42:09 -0700] rev 315937 Added license file for xhtml1-dtds zip	matthiasblaesing	Done	externalized file was already removed and the containing files added directly to the codebase
changeset Reema <Reema@netbeans.org> [Wed, 31 May 2017 21:26:00 -0700] rev 315934 Moved xhtml1-dtds to external zip	matthiasblaesing	Done	Files are already reintegrated into the codebase
changeset Arusinha <arusinha@netbeans.org> [Wed, 31 May 2017 01:56:00 -0700] rev 315931 deleted files from release-leftovers list-1
changeset Reema <Reema@netbeans.org> [Wed, 31 May 2017 00:56:39 -0700] rev 315929 moved websvc.saas.api xsd to external zip	matthiasblaesing	Done	removed XSDs were already readded
changeset Arusinha <arusinha@netbeans.org> [Tue, 30 May 2017 22:20:50 -0700] rev 315927 deleted files from nb.cluster.java and nb.cluster.profiler list	matthiasblaesing	Done	j2ee.persistince DTDs+XSDs were already readded, hibernate dtds are license incompatible (LGPL) and can't be readded.
changeset Reema <Reema@netbeans.org> [Tue, 30 May 2017 07:38:28 -0700] rev 315926 Removed author names from files	lbruun	Done	Changes are irrelevant to Apache NetBeans. No action required.
changeset Reema <Reema@netbeans.org> [Tue, 30 May 2017 00:26:21 -0700] rev 315924 Deleted files from .ide, .websvccommon			Removes - among other things - all IDE registered web service clients. (Amazon, Google, Flickr, etc). Honestly I don't know how many people will miss this, but we should at least investigate if New Web Service Client --> IDE Registered --> Browse will 'fail' gracefully.
changeset Arusinha <arusinha@netbeans.org> [Mon, 29 May 2017 07:50:59 -0700] rev 315922 deleted files from nb.cluster.profiler review list-2	matthiasblaesing	Done	Prebuild binaries for Profiler are released as CDDL and are moved to external.
changeset Arusinha <arusinha@netbeans.org> [Sun, 28 May 2017 22:01:38 -0700] rev 315921 nb.cluster.java review 1			This is a rather large change with lots of files removed. Suggest to focus initially only on those files not related to `test`. As a minimum the following modules should be reviewed:
	matthiasblaesing	PR336	`maven.checkstyle` : XMLs and DTDs removed
	matthiasblaesing	PR336	`maven.coverage` : DTDs removed
	matthiasblaesing	PR336	`maven.embedder`: The changes look ok - the removed jars seem to be duplicates. They are all part of the apache-maven-3.3.9-bin.jar
	matthiasblaesing	PR336	`maven.grammar`: XSDs removed. Readded by PR-280 and PR-281. Except for nbm-1.0.0.xsd which isn't at Apache, and which could not be found.
	matthiasblaesing	PR336	`spring.beans`: XSDs and DTDs removed
	matthiasblaesing	PR336	`xml.jaxb`: XSD removed
changeset Arusinha <arusinha@netbeans.org> [Fri, 26 May 2017 05:46:18 -0700] rev 315912 deleted files from nb.cluster.nb review	lbruun	Done	Fixed in PR241
changeset Reema <Reema@netbeans.org> [Fri, 26 May 2017 03:53:05 -0700] rev 315911 Replaced logo icons,del files .ide review list - 3			Logos for "Oracle" and "Java" are replaced with the standard NetBeans logo. This affects Options window, userguide and Start Page. It looks stupid but is not catastrophic. In addition a lot of schema files are removed but they all relate to test.
changeset Reema <Reema@netbeans.org> [Thu, 25 May 2017 00:54:49 -0700] rev 315905 deleted files from nb.cluster.ide review list - 2			Terminal definitions for ansi, xterm, dterm, etc are removed. Impact unknown. In addition a lot of schema files are removed but they all relate to test.
changeset Arusinha <arusinha@netbeans.org> [Wed, 24 May 2017 19:37:50 -0700] rev 315898 deleted files from nb.cluster.profiler review list-1			All changes here relate to Profiler.
changeset Arusinha <arusinha@netbeans.org> [Tue, 23 May 2017 23:21:40 -0700] rev 315895 deleted files from nb.cluster.harness review list-1			Only removes files that can be recreated from the build. (wonder why they were in source control in the first place)
changeset Arusinha <arusinha@netbeans.org> [Tue, 23 May 2017 08:03:35 -0700] rev 315893 deleted files from nb.cluster.platform review list-1	matthiasblaesing	Done	Tests are already fixed javahelp was removed and will need a replacement (already identified as a problem as it is GPLv2CPE) rest is test-only
changeset Reema <Reema@netbeans.org> [Tue, 23 May 2017 04:42:18 -0700] rev 315891 deleted files from nb.cluster.ide review list - 1			All removed files relate to test.
changeset Arusinha <arusinha@netbeans.org> [Mon, 22 May 2017 23:21:59 -0700] rev 315889 deleted files from o.n.bootstrap for Apache Donation			Removes a .res file (binary resource file for Windows). Such a file is an interim result of the build process and the it probably shouldn't have been in source control in the first place.
changeset Reema <Reema@netbeans.org> [Mon, 22 May 2017 22:14:54 -0700] rev 315888 Files to delete : apisupport			Changes all relate to test or to sample PaintApp. Seems ok.
changeset PGebauer <pgebauer@netbeans.org> [Wed, 17 May 2017 11:03:09 +0200] rev 315847 The binary launcher for Mac OS X is not used.	matthiasblaesing	Done	The macosx dmg file was removed - looks sensible. The unix starter shell script has support for Darwin (the system macosx is based on)
changeset PGebauer <pgebauer@netbeans.org> [Tue, 16 May 2017 11:23:43 +0200] rev 315844 The move of platform binary launchers to the external binaries storage.	matthiasblaesing	Done	Prebuild windows launchers (dll+exe) were extracted and externalized. The license is ok, as the CDDL is one of the licenses and should so be ok. The source for the windows launcher is present and was relicensed.
changeset PGebauer <pgebauer@netbeans.org> [Fri, 12 May 2017 14:37:10 +0200] rev 315828 The correction of license files.	matthiasblaesing	Done	This changes the license from GPL to CDDL-GPL-2-CP (followup for 315827)
changeset PGebauer <pgebauer@netbeans.org> [Fri, 12 May 2017 14:26:00 +0200] rev 315827 The move of binary launchers to the external binaries storage.	matthiasblaesing	Done	Prebuild windows launchers (dll+exe) were extracted and externalized. The license is ok, as the CDDL is one of the licenses and should so be ok. The source for the windows launcher is present and was relicensed.
changeset Milutin Kristofic <mkristofic@netbeans.org> [Thu, 30 Mar 2017 11:38:28 +0200] rev 315732 Add Licenses	matthiasblaesing	Done	No action required, CDDL-GPL-2-CP licenses were added to sources. Module review should have taken care of it.
changeset Milutin Kristofic <mkristofic@netbeans.org> [Tue, 25 Apr 2017 13:52:33 +0200] rev 315731 Stripping profiles from images			lbruun: I think the commit text means color profiles stripped from PNGs, GIFs, etc.This is image metadata. Not sure it has any impact at all to remove. I think the color profile is only relevant if you want to edit the icon and even in that case I'm not sure it is needed. Anyone knows anything about PNGs, GIFs, etc? .. and can confirm this assumption.
changeset Milutin Kristofic <mkristofic@netbeans.org> [Wed, 26 Apr 2017 14:44:51 +0200] rev 315730 Changing third-party icons to Netbeans default icon	lbruun	Done	Lots of icons changed to dummy NetBeans icon. NETBEANS-126 and ~~PR251~~, later replaced by PR289.
changeset PGebauer <pgebauer@netbeans.org> [Mon, 19 Dec 2016 12:16:55 +0100] rev 313960 The donation_review branch created.	lbruun	Done	This is just a row to convey when the branch started. No action required.

JIRA issues related to fixing issues in the donation

(those with label 'donation-fixes')