This Confluence has been LDAP enabled, if you are an ASF Committer, please use your LDAP Credentials to login. Any problems file an INFRA jira ticket please.

Child pages
  • Code Review Guidelines
Skip to end of metadata
Go to start of metadata

Please refer to How to Contribute for instructions how to submit a code review to Github.

What makes a good code review?

  1. Authors should annotate source code before the review. This makes it easier for devs reviewing your code and may even help you spot bugs before they do.
  2. Send small code-reviews if possible. Reviewing more than 400 lines per hour diminishes our ability to find defects.
  3. Reviewing code for more than one hour also reduces our ability to find bugs.
  4. If possible, try to break up large reviews into separate but functional stages. If you need to temporarily comment out unit tests, do so. Sending gigantic patches means your review will take longer since reviewers need to block out more time to go through it, and you may spend more time revving iterations and rebasing.

We have a global community of committers, so please be mindful that you should wait at least 24 hours before merging your pull request even though you may already have the necessary +1.
This encourages others to take an interest in your pull request and helps us find more bugs (it's ok to slow down in order to speed up).

Always include at least two committers that are familiar with that code area.
If you want to subscribe to code reviews for a particular area, feel free to edit this section.

AreaExample FilesReviewers (reviewboard id)
Ambari AlertsAlert*.java
alert_*.py 
jhurley
Ambari Agent/ambari-agent/* 
Ambari Metrics System/ambari-metrics/*swagle, avijayan
Ambari Views/ambari-views/* 
Ambari Server
(threads, caching, lifecycle) 
/ambari-server/*swagle, ncole, jhurley, afernandez
Ambari REST API
(/api/v?/....) 

*Service.java
*ResourceDefinition.java
*ResourceHandler.java

rlevas, dili, jluniya
Ambari Infra/ambari-infra/*oleewere
Blueprints Blueprint*.javarnettleton
LogSearch/ambari-logsearch/*

oleewere, miki.gergely

Rolling & Express Upgrade

*upgrade.xml
config-upgrade.xml
hdp select, conf select 

afernandez, ncole, jhurley, dmitriusan,

dili, tthorpe

Security, Kerberos, LDAPjava files and kerberos.jsonrlevas
Stack Advisorstack_advisor.pysrimanth, tthorpe
Stack Frameworkmetainfo.xml, any config filesjluniya, tthorpe, jmarron, swapan, mradha25
UI/ambari-web/*yusaku, rzang, jwang
Mpack

setupMpacks.py

Mpack*.java

Registry*.java

jluniya, swapan, mradha25, thorpe




  • No labels