Current state: Accepted
Discussion thread: here
Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).
Note: The discussion in this KIP applies to Java based (new) consumer only as the security feature is not supported by the old consumer.
From an authorization and ACL point of view, three operations (permission types) are defined for consumer groups: Describe, Read, All. By default, Read implies Describe, and All implies all the other operations.
Current consumer group related APIs and their minimum required permissions are listed in the following table:
|API||Minimum Required Permission|
The pattern we can see in this table is that a minimum Read permission is used for mutating APIs, whereas a minimum Describe permission is used for non-mutating APIs. One exception to this pattern is
OffsetFetch, which is a non-mutating API, but requires a Read access. A Read access requirement for
OffsetFetch is too restrictive, and unnecessary. Consider the following example by @ewencp in the corresponding JIRA's description: If we want to write a tool that only monitors offsets (no commits), we cannot achieve it with the current ACL settings. Because accessing the
OffsetFetch API requires a Read permission; but a Read permission means we are also authorized to use the
CommitOffset API (side note: for this tool to be able to read offsets of a group, it needs to have Describe access to the topics the group is consuming from. In other words, the tool will be able to see offsets of all topics (topic partitions) in the group it has Describe access to).
The other, and perhaps more compelling, incentive for this change is that the current ACL settings breaks a certain functionality (and this functionality seems to have been broken for a while). As mentioned in the above table the minimum required permission for
OffsetFetch is Describe and Read, respectively. But implementation of the describe group command line makes use of
OffsetFetch API (version 0 and 1 pre-KIP-88, and version 2 post-KIP-88). Therefore, a user who is granted the current minimum requirement permission Describe for
DescribeGroup still would not be able to run the describe group command and get the expected result. They would see something like this in the output:
If we make the change suggested in the next section, the command runs successfully and reports the group offsets.
The following potential unit tests in
scala.integration.kafka.api.AuthorizerIntegrationTest could further clarify the problem.
The change proposed by this KIP is very simple: to lower the minimum required permission of the
OffsetFetch API from Read to Describe. These minimum required permissions are hard-coded in
kafka.server.KafkaApis.scala inside each API handler method. For example, the part that enforces the minimum required permission for the
OffsetFetch API currently looks like this:
And the proposal is to to modify it to:
Compatibility, Deprecation, and Migration Plan
- A user that already has Read permission to a consumer group, with this change, would still be able to query the group like before (Read implies Describe). For this user the change is backward compatible.
- Consider a user with Describe access. The group Describe access implies access to
FindCoordinatorAPIs; even though this user cannot make use of
DescribeGroup, as explained above. Giving this user access to
OffsetFetchAPI means fixing that broken experience.
In general, As a result of this change, Kafka admins may need to revisit the relevant ACLs and update them if necessary.