Review-then-commit (RTC) for code

  1. Changes to REEF's code must have an associated JIRA item.
  2. REEF uses review-then-commit (RTC). Code contributions must be reviewed by a committer before they are merged.
  3. The actual merge does not have to be done by the committer that reviewed it.
  4. Code contributions are accepted only via Pull Requests on GitHub. See the Contributor's Guide for details.

Source: Standing practice in REEF as of 2016-03-21

Commit-then-review (CTR) for Documentation

  1. Documentation updates to non-code files can be committed by any committer with no review requirement.

  2. However, it is up to the committer to decide whether they'd like the change to be reviewed as above

  3. The documentation updates must include "[Documentation] A short summary" as the first line in the commit.

Source: Vote concluded on the dev list on 2016-03-21.

  • No labels