Agenda

Commits review
JIRA Review
AOCBRich Text

Outstanding actions

revision

committer

date

comment

review comments

r659163

arnaudsimon

2008-05-22

QPID-1079 : Updated ...test.client tests for using QpidTestCase + move QpidTestCase in main so it is visible form systests

RECEIVE_TIMEOUT : get rid of and use configurable timeout when available

r669431

rgodfrey

2008-06-19

QPID-950 : Broker refactoring, copied / merged from branch

 

r669480

rgodfrey

2008-06-19

QPID-950 : Fixed Derby Message Store

 

r661746

ritchiem

2008-05-30

QPID-1101 : Update to DestNameExchange to perform deep copy.

Needs test

r662755

arnaudsimon

2008-06-03

QPID-1115 : Only generate client ID when necessary

RG to comment on Jira

r662770

ritchiem

2008-06-03

QPID-1092 : Changed toString to be String.valueOf(getObject()) Added MessageToStringTest, tests performing toString on Message before calling getObject().

Weird catch in close()

r662827

arnaudsimon

2008-06-03

QPID-1112 : Update previous commit by re-using messageAcknowledge (added a flag specifying whether to send an messageAccept)

inRecover check in BMC_0_10.postDeliver might be a problem with async delivery

r665841

rhs

2008-06-09

QPID-901 : always reset the auto-sync mode even if the call fails

RHS:  make sure flag is used where appropriate

r667561

ritchiem

2008-06-13

QPID-1136 : Provided a fix for the leak in UnacknowledgedMessage when acking. Added a new InternalBrokerBaseCase for performing testing on the broker without using the client libraries. This allows fo ...

InternalMinaProtocolSession has a bug in awaitDelivery where it can hang because deliveryCount is already set to !0

r669841

rgodfrey

2008-06-20

QPID-1144 : Reference count drops to zero too early for immediate messages in a txn

RG: document LocalTransactionalContext

r669885

rgodfrey

2008-06-20

QPID-1101 : Updated Direct Exchange so it does not modify lists of queues

No Test

r671845

aidan

2008-06-26

QPID-854 QPID-999 : Merge Changes to the client to make the dispatcher responsible for closing the queue browser when all the messages have been processed.

JIRA clean up of anon CloseMessage DeliveryBody class.

r671949

ritchiem

2008-06-26

QPID-909 : Commented out the TimerTask so that it can be wrapped with a ScaledTestDecorator. Minimal change to get our existing tests to run. If closer duration control is required then further time c ...

Change Commit list

r672810

rajith

2008-06-30

This commit is related to QPID-1161 . Please refer to the JIRA for complete details. In Summary this contains a simple test kit comprising of perf and soak tests. The focus is on producing a packaged ...

 

r674085

ritchiem

2008-07-04

QPID-871 - Added a ConnectionRegistry per Virtualhost to track the open connections. Altered the ApplicationRegistry so that when the shutdown hook is fired it: Unbinds from the listening sockets Then ...

 

Commits

revision

committer

date

comment

 

r672032

aconway

2008-06-26

Plugin framework change: single PluginFactory creates per-target Plugin instances.

 

r672269

aconway

2008-06-27

Fix exit status when VALIGRIND=

 

r672280

arnaudsimon

2008-06-27

QPID-1157 : Added CC scripts and config files

 

r672296

ritchiem

2008-06-27

Added qpid/java/release to ignore list

 

r672300

ritchiem

2008-06-27

Updated the performance tests to ensure we use all the available test, added additional comments in pom.xml about each test section.

Why update maven?

r672303

ritchiem

2008-06-27

Added comment to gitignore to explain previous additions

 

r672763

aidan

2008-06-30

QPID-1159 : remove @Override tags

 

r672766

arnaudsimon

2008-06-30

QPID-1157 : Added cc example automation scripts

 

r672810

rajith

2008-06-30

This commit is related to QPID-1161 . Please refer to the JIRA for complete details. In Summary this contains a simple test kit comprising of perf and soak tests. The focus is on producing a packaged ...

 

r672854

tross

2008-06-30

Switch to async mode for management communication

 

r672855

tross

2008-06-30

Cosmetic change: rename ID to be 'tag'

 

r672864

tross

2008-06-30

QPID-1160 - Per-thread counters in management API to avoid locking

 

r673031

gsim

2008-07-01

Added extra option (fixed time limit in rate mode) to latency test. Patch from acme@redhat.com.

 

r673058

rgodfrey

2008-07-01

QPID-1084 : Applying patch previously applied to M2.x

 

r673071

arnaudsimon

2008-07-01

QPID-1157 : Updated scripts

 

r673074

arnaudsimon

2008-07-01

QPID-1163 : Moved message ack in pre-deliver method

Needs test.
Commenting out of preDeliver 
Group review of
BasicMessageConsumer* 
Check inRecovery change

r673082

aidan

2008-07-01

QPID-887 : name housekeeping thread properly. Apply patch from suran at wso2 dot com

 

r673158

aconway

2008-07-01

Added timeout to SubscriptionManager::get(), LocalQueue::get() and BlockingQueue::get()

 

r673343

aidan

2008-07-02

QPID-962 Exception handling was... unpleasing... Fix up of patch from rhs AMQConnection: Refactor listener and remove list, we're only interested in the most recent one anyway. Add get/set for lastEx ...

 

r673347

aidan

2008-07-02

QPID-960 make protocol negotiation work from 0-10 down to 0-9 and then 8-0 still needs love to do with railover, see QPID-959 AMQConnection.java: use 8_0 delegate for in-vm tests AMQConnectionDelegat ...

 

r673350

aidan

2008-07-02

QPID-960 copy delegate properly

 

r673351

aidan

2008-07-02

QPID-960 remember to rename class

 

r673359

gsim

2008-07-02

Improved text and rasied severity of log entry when client sessions are deleted without first being closed.

 

r673401

aidan

2008-07-02

Revert "QPID-962 Exception handling was... unpleasing... Fix up of patch from rhs" This reverts commit 673343.

 

r673688

aidan

2008-07-03

QPID-962 Exception handling was... unpleasing... Fix up of patch from rhs AMQConnection.java: Refactor listener and stack exceptions in a list. Add get lastException, which can now be any Exception. ...

 

r673718

tross

2008-07-03

QPID-1160 - Use array-style delete for allocated array

 

r673725

aconway

2008-07-03

rubygen: Change default for client API accept-mode parameters to 1.

 

r673947

ritchiem

2008-07-04

Removed SimpleACLTest from the build whilst we resolve the client exception handling problems causing the failure

 

r674003

gsim

2008-07-04

Only override default value for accept-mode field in message.transfer (not message.subscribe)

 

r674015

arnaudsimon

2008-07-04

QPID-1157 : Added perftests project

 

r674040

gsim

2008-07-04

Allow default values for packed structs to be overridden (currently used for message.transfer.accept-mode)

 

r674055

arnaudsimon

2008-07-04

QPID-1079 : Remove all classes that were no longer referenced + updated FlowControlTest for using QpidTestCase

 

r674058

ritchiem

2008-07-04

Qpid-940 - ConnectionTest#testPasswordFailureConnection fails occasionally so while these race conditions are addressed I've converted the ConnectionTest to QpidTestCase and use it to skip the Passwor ...

 

r674085

ritchiem

2008-07-04

QPID-871 - Added a ConnectionRegistry per Virtualhost to track the open connections. Altered the ApplicationRegistry so that when the shutdown hook is fired it: Unbinds from the listening sockets Then ...

 

r674097

ritchiem

2008-07-04

QPID-940 : Forgot to exclude the test from the test run

 

r674102

ritchiem

2008-07-04

Addition of tools directory for various Qpid Java tools The first too JNDICheck allows the contents of a JNDI properties file to be parsed and presented as JNDI will process it. Handly for validating ...

 

r674107

aconway

2008-07-04

Cluster prototype: handles client-initiated commands (not dequeues) Details - Cluster.cpp: serializes all frames thru cluster (see below) - broker/ConnectionManager: Added handler chain in front of ...

 

r674113

aconway

2008-07-04

Remove debugging cout accidentally left in.

 

r674124

aconway

2008-07-04

Disabled cluster_test temporarily, it leaks processes.

 

r674389

rajith

2008-07-07

The last checkin for this class was using a Java 1.6 specific method called isEmpty in the String class. This fails the build in Java 1.5. I modified it to use str.length == 0 which has the same effec ...

 

r674391

rajith

2008-07-07

This is related to QPID-1161 . Made minor modifications to the scripts and added a log4j file for the tests. The scripts are now modified to use the JAVA_HOME.

 

r674392

rajith

2008-07-07

This is related to QPID-1161 . Added the absolute path to setevn.sh, so that the following scripts can be called from any location.

 

r674482

gsim

2008-07-07

Temporarily reverting changes to signal handling; as checked in by r674107 it prevents the broker being shutdown.

 

r674493

aconway

2008-07-07

configure.ac: check for cpg_local_get to exclude older CPG versions.

 

r674504

aconway

2008-07-07

Restore use of SignalHandler in qpidd.cpp, fixed errors in previous commit.

 

r674510

aidan

2008-07-07

QPID-474 Make sure that our SASL servers actually, y'know, validate the password AmqPlainSaslServer.java: Actually check password PlainSaslServer.java: Actually check password SaslServerTestCase.java ...

Need to define security notification mechanism

r674513

aidan

2008-07-07

QPID-474 forgot ASL header, oops

 

r674541

aidan

2008-07-07

Disable certain ConnectionTest tests since the 010 broker doesn't currently implement that behaiour

 

r674569

rajith

2008-07-07

This is related to QPId-1161. Modified the soak tests to print latency samples and throughput rates for every iteration. Added run_soak_client.sh soak_report.sh as an example of how to use soak test a ...

 

r674587

aconway

2008-07-07

ForkedBroker: child process exits on completion.

 

r674622

rajith

2008-07-07

This is related to QPID-1162 Added a README file to describe what the tests are and how they can be run. Modified to consumers to print the iteration number instead of the message id.

 

r674747

aidan

2008-07-08

QPID-293 allow messages which have been received by the consumer before a message listener has been set to be delivered. BasicMessageConsumer.java: If there are messages on the synchronous queue when ...

 

r674825

aconway

2008-07-08

Fix leak in XmlClientSessionTests - was leaking a Session.

 

r674826

aconway

2008-07-08

svn:ignore properties.

 

r674848

gsim

2008-07-08

  • release message lock when notifying queue listeners * take copy of listeners * remove unused functionality

 

r674855

aconway

2008-07-08

Removed static Cpg::handlers, fixed ForkedBroker shutdown.

 

r674865

aconway

2008-07-08

QPID-1148 - from Manuel Tiera Lock file abstraction in sys/ with implementation portable to Linux and Solaris. Changes by myself: - Makefile.am - must be updated for any new/renamed/removed source ...

 

r674915

aconway

2008-07-08

Revert un-necessary Plugin complications. Better solution for plugin extension points coming up...

 

r674939

rhs

2008-07-08

Branch at a stable point for 0-10 support (prior to M3). This includes the C++ broker, C++ client, Java client, and Python client all speaking the 0-10 protocol.

 

r674945

aconway

2008-07-08

Fix packaging error.

 

r674955

aconway

2008-07-08

Remove unused Serializer code.

 

r674976

rajith

2008-07-08

This is related to QPID-1161 . Added the ability to pass in JVM ARGs.

 

r674994

tross

2008-07-08

QPID-1170 - Remove boost dependency from management agent interface

 

r675017

aconway

2008-07-08

HandlerChain: plug-in handler chain extension points. Replaces Handler<T>::Chain. Updated Sessoin & Connection handler chains and Cluster.

 

r675144

aconway

2008-07-09

Fix for older boost versions

 

r675146

aconway

2008-07-09

Fix signed/unsigned compare error

 

r675155

aconway

2008-07-09

Removed dead code.

 

r675165

rhs

2008-07-09

Primarily profiling driven changes: - added batched writes of commands/controls issued on a session - copy fragmented frames and segments rather than trying to decode them piecemeal, removed Fr ...

 

r675252

gsim

2008-07-09

Allow for pluggable exchange types.

 

r675338

astitcher

2008-07-09

Some small changes which clean up header file inclusions and generally start to tidy up the network layer so that it's a bit easier to implement new network transports

 

r675397

rhs

2008-07-10

QPID-1062 : moved channel id into the ProtocolEvent interface and removed ConnectionEvent, this removes the overhead of creating ConnectionEvents

 

r675433

rhs

2008-07-10

QPID-1171 : batch acks when prefetch is used

 

r675477

gsim

2008-07-10

Honour timeout in BlockingQueue::pop(); added test for SubscriptionManager::get() where no message exists.

 

r675486

gsim

2008-07-10

Assume accept-mode=1 (i.e. none required) where not explicitly specified on a message.transfer

 

r675598

gsim

2008-07-10

Add a get() method to subscription manager that retrieves one message from the specified queue if available, returns false otherwise.

 

r675674

tross

2008-07-10

Move shutdown of management broker to end of shutdown sequence

 

r676067

tross

2008-07-11

QPID-1174 Remote Management Agent for management of external components

 

r676581

gsim

2008-07-14

Allow for pluggable exchange types.

 

r676613

rajith

2008-07-14

This is related to QPID-1163 . This is already in trunk and I am porting it to the qpid.0-10 branch.

 

r676831

aidan

2008-07-15

Multi-version interop test script

 

r676878

ritchiem

2008-07-15

QPID-909 Added missing license header and fixed execute bit on MessageSize.sh Added RunAll.sh for good measure

 

r676879

ritchiem

2008-07-15

Updated gitignore with cpp example output and other generated files

 

r676883

ritchiem

2008-07-15

QPID-1175 : VirtualHost now validates that name is non-null and non-empty. Full protocol validation of the virtualhost name has not been performed.

 

r676884

ritchiem

2008-07-15

QPID-1176 : Updated Tasks and gentools build to use the java.source and java.target values. Added echo statements to show the targeted build Updated other info echo statements to be an info level so t ...

 

r676885

ritchiem

2008-07-15

Updated log4j format as per discussion on mailing list.

 

r676886

ritchiem

2008-07-15

Removed the non ASCII characters that are causing the build to minorly complain.

 

r676887

ritchiem

2008-07-15

QPID-1172 : Moved unregistration out of the sendLock. Potential refactor possible between processQueue and flushSubscription

 

r676932

aconway

2008-07-15

Switched from shared_ptr to intrusive_ptr and RefCounted for Broker.

 

r676938

rajith

2008-07-15

This is related to QPID-1102 . I have fixed the error handling and revised the while loop in IoSender based on the comments received during the code review

 

r676951

aidan

2008-07-15

fix cpp client, path changes

 

r676963

aconway

2008-07-15

Fix "ignoring return value" warning from LockFile.h.

 

r676969

ritchiem

2008-07-15

QPID-1079 : Based on Code Review : Remvoed AutoCreateVMBroker code from QpidTestCase. Removed VMTestCase and all references to it, it was only used in JUnit4 testSuite wrappers. Rather than move QpidT ...

 

r676971

ritchiem

2008-07-15

QPID-1079 : Based on Code Review : Remvoed AutoCreateVMBroker code from QpidTestCase. Removed VMTestCase and all references to it, it was only used in JUnit4 testSuite wrappers. Rather than move QpidT ...

 

r676972

ritchiem

2008-07-15

QPID-1176 : Update to gentools to remove commented out properties that I left in via git (sad)

 

r676973

ritchiem

2008-07-15

QPID-984 : Applied fix from M2.1.x that adds requried synchronization around setup and tear down of Connections.

 

r676978

ritchiem

2008-07-15

QPID-940 ,QPID-594 ,QPID-805 ,QPID-826 : Updated the client exception handling so that exceptions are not lost. In performing the changes I noted that the AMQStateManager is only used for connection crea ...

 

r676982

ritchiem

2008-07-15

QPID-1177 : Added Protocol Level Debug logging. Uses a final static so should JIT out if disabled. To enable set -Damqj.protocol.logging.level=info

 

r677256

ritchiem

2008-07-16

QPID-1178 : Prevent Rejecting messages destined for known QueueBrowsers

 

r677257

ritchiem

2008-07-16

Changed erroneous error level logging to info level

 

r677258

ritchiem

2008-07-16

Added a warning log statement if the TransportConnection autocreates an InVM Broker

 

r677259

ritchiem

2008-07-16

Converted client.failover.FailoverTest so it can utilise the standard mechanism for failover testing, as the local CruiseControl had testP2PFailoveWithMessagesLeft fail with extra messages being left ...

 

r677260

ritchiem

2008-07-16

QPID-1179 : Adjusted the test size from 100 to 10, this should reduce the likely hood of a slow machine failing the test.

 

r677262

ritchiem

2008-07-16

Renamed shutdownServer to restartBroker as that is what is does

 

r677263

ritchiem

2008-07-16

QPID-1181 : Added additional logging to help diagnose a NullPointerException

 

r677319

ritchiem

2008-07-16

Update to the logging to ensure QpidTestCase is always logged and standardized the protocol output format between 0-8/0-9 and 0-10

 

r677327

ritchiem

2008-07-16

QPID-871 : The shutdown change had a spurious getInstance() call which would case a new instance of ID 1 to be created if there wasn't one, it would then procede to shutdown that MBeanServer not the M ...

 

r677408

tross

2008-07-16

QPID-1170 - Provide a better factory for creation and deletion of the management agent

 

r677412

tross

2008-07-16

QPID-1170 - Removed spurious include from example

 

r677471

aconway

2008-07-17

Cluster: shadow connections, fix lifecycle & valgrind issues. - tests/ForkedBroker: improved broker forking, exec full qpidd. - Plugin::addFinalizer - more flexible way to shutdown plugins. - Rewo ...

 

r677486

aconway

2008-07-17

Enable dequeue for prototype cluster - qpid/broker/SemanticState.cpp: moved doOutput into write idle callback. - qpid/broker/Connection.cpp: make doOutput an intercept point. - qpid/cluster/*: inte ...

 

r677525

ritchiem

2008-07-17

QPID-1177 : Fixed the format of the messages, realised that the transport.Connection uses a logging wrapper but in my haste to make the format the same in AMQProtocolHandler hadn't checked the output ...

 

r677629

ritchiem

2008-07-17

Moved the Reflection Wrapping code used by the system tests to the system test. If they are left in common then we must include the common directory when using the systest-testing frameworks no matter ...

 

r677633

ritchiem

2008-07-17

QPID-1182 : Added additional logging to identify the exception that caused Authentication to fail.

 

r678211

rhs

2008-07-19

QPID-1184 : redirect stdout and stderr from QpidTestCase

 

r678260

rhs

2008-07-20

QPID-1185 : replaced occurrances of with , also made default.testprofile always load so that all other testprofiles only need to override values that are different

 

r678759

gsim

2008-07-22

Fix to transaction batching. (Backport of r669215).

 

r678848

rhs

2008-07-22

Updated the io transport to use a separate write thread with a circular buffer that does opportunistic write batching. Fixed error handling and shutdown for the io transport. Switched default from min ...

 

r679038

gsim

2008-07-23

Further fixes to transactional perftest: * correction to transaction boundaries * ensure any outstanding acks are sent on completion of subscriber

 

r679045

gsim

2008-07-23

Fixes for transactional perftest (merge of r679038 from qpid.0-10)

 

r679048

gsim

2008-07-23

QPID-1183 : Use the right sizes to insert data inside the message payload where sizeof(size_t) != sizeof(uint32_t). Patch from Manuel Teira.

 

r679059

ritchiem

2008-07-23

QPID-1187 : The broker did not correctly handle subscriptions that would suspend due to exhaustion of bytes credit. The processQueue loop would spin, this fix marks the subscription inactive for that ...

 

r679105

arnaudsimon

2008-07-23

qpid-1157: added jms tck scripts + README file + config file for setting email related properties

 

r679232

rhs

2008-07-23

excluded a known-failing test for durable subscriptions, the fix is on trunk and doesn't as yet need to be backported

 

r679268

astitcher

2008-07-24

Refactor to change client connector state machine to be held in ConnectionHandler

 

r679276

astitcher

2008-07-24

Refactored so that Dispatcher is now independent from DispatchHandle

 

r679462

gsim

2008-07-24

Set a configurable default size limit on queues

 

r679469

gsim

2008-07-24

Allow configurable default size limit to be set for queues (merged from r679462).

 

r679481

arnaudsimon

2008-07-24

qpid-1157: updated java trunk so a report is generated when there is a fault

 

r679689

gsim

2008-07-25

QPID-447 : Optional mechanism to avoid race when automating topic tests. Patch from David Sommerseth.

 

r679699

gsim

2008-07-25

QPID-447 : Patch from David Sommerseth merged from r679689.

 

r679717

gsim

2008-07-25

QPID-1154 , QPID-1155 & QPID-1156 : Patches from Steve Huston to fix various minor compiler errors.

 

r679739

gsim

2008-07-25

Fixed bug in SubscriptionManager::get() where flush was issued before waiting and if message showed up after flush completed but before wait was finished there was no credit (due to flush) to deliver ...

 

r679748

gsim

2008-07-25

Merged fix to SubscriptionManager (was r679739)

 

r679756

gsim

2008-07-25

Exclude core verify script from verifications run when python examples cannot be found.

 

r679762

aidan

2008-07-25

Add xslt magic for creating code review agenda, and add wrapper script

 

Jiras

Key

Component(s)

Affects Version/s

Summary

Status

Assignee

Reporter

Review Comments

QPID-1182

Java Broker

 

(QPID-1182) SimpleACLTest authentication failures

Open

Martin Ritchie

Martin Ritchie

 

QPID-1183

C++ Broker

M3

(QPID-1183) perftest doesn't work correctly when sizeof(size_t) != sizeof(uint32_t)

Resolved

Unassigned

Manuel Teira

 

QPID-1184

Java Tests

M3

(QPID-1184) all output during tests is buffered until the test case finishes

Open

Rafael H. Schloming

Rafael H. Schloming

 

QPID-1185

Ant Build System

M3

(QPID-1185) -Dlog=foo is ignored

Open

Rafael H. Schloming

Rafael H. Schloming

 

QPID-1186

Java Client

M2.1

(QPID-1186) (Client Race Condition) After Failover client can ack last message from previous session.

Open

Martin Ritchie

Martin Ritchie

 

QPID-1187

Java Broker

M3

(QPID-1187) Java Broker appears to be stuck in a loop

In Progress

Martin Ritchie

Martin Ritchie

 

QPID-1188

Java Client

M3

(QPID-1188) java 0-10 client deadlocks when running with -Dprotectio=true

Open

Rafael H. Schloming

Rafael H. Schloming

 

QPID-1189

Java Broker

M3

(QPID-1189) Ant target need to be execute twice to build Qpid

Open

Unassigned

Asanka Abeysinghe

 

QPID-1190

Java Broker

M3

(QPID-1190) Broker logs 0-10 negotiation failure

Open

Marnie McCormack

Aidan Skinner

 

QPID-1191

Java Broker, JMS Compliance

 

(QPID-1191) Enable Exchange level filters.

Open

Martin Ritchie

Martin Ritchie

 

QPID-1192

Java Client, JMS Compliance

 

(QPID-1192) Client needs to send selector string as part of Binding request when using topics

Open

Martin Ritchie

Martin Ritchie

 

QPID-1193

Java Broker MessageStore - DerbyStore

 

(QPID-1193) Bind arguments must be stored with binding in DerbyStore

Open

Martin Ritchie

Martin Ritchie

 

QPID-1194

Java Broker, Java Client

 

(QPID-1194) Enable Selector use on JMS Topics in the Java Broker

Open

Martin Ritchie

Martin Ritchie

 

QPID-1195

Java Broker

 

(QPID-1195) Recovery with Argument Maps

Open

Martin Ritchie

Martin Ritchie

 

QPID-1196

Java Broker, Java Broker MessageStore - DerbyStore

 

(QPID-1196) Queue Entries should be in terms of id's not queue -names

Open

Martin Ritchie

Martin Ritchie

 

QPID-1197

Java Broker

 

(QPID-1197) Improve persistent recovery

Open

Unassigned

Martin Ritchie

 

QPID-1198

C++ Broker

M3

(QPID-1198) Changes for the solaris port

Open

Andrew Stitcher

Manuel Teira

 

  • No labels