Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • When filing PRs, remember to 
    • Rebase your fork (http://stackoverflow.com/a/7244456/1110993)
    • Squash your commits
    • Create a JIRA for your bug fix/feature enhancement - point the JIRA "External Issue URL" to your PR URL
    • Preface your commit's subject & PR's title with [GOBBLIN-XXX], where XXX is the JIRA number, and add a JIRA link in the PR description
      • Some folks only preface the PR title with [GOBBLIN-XXX], but we also need the commit message subject to contain the JIRA id. This is because we use the subject line in the commit messages when creating the release notes. 
    • Add an Apache License header to all new files
    • & follow the 7 rules of good Git commits
    • Gobblin committers will review your submission, and approve or deny based on quality and relevance
    • We expect the code contributions to be your original work, and if accepted in Apache Gobblin, would be distributed under Apache 2.0 license