...
This topic has also been previously discussed on the Dev mailing list in https://lists.apache.org/thread/q62nj89rrz0t5xtggy5n65on95f2rmmx
Public Interfaces
...
- The following interfaces will be
...
- marked as
@Deprecated- org.apache.flink.streaming.api.functions.sink#SinkFunction
- org.apache.flink.streaming.api.functions.sink#SocketClientSink
- org.apache.flink.streaming.api.functions.sink#TwoPhaseCommitSinkFunction
- The following interfaces will be marked as
@Public- org.apache.flink.api.connector.sink2#Committer
- org.apache.flink.api.connector.sink2#CommitterInitContext
- org.apache.flink.api.connector.sink2#CommittingSinkWriter
- org.apache.flink.api.connector.sink2#Sink
- org.apache.flink.api.connector.sink2#SinkWriter
- org.apache.flink.api.connector.sink2#StatefulSinkWriter
- org.apache.flink.api.connector.sink2#SupportsCommitter
- org.apache.flink.api.connector.sink2#SupportsWriterState
- org.apache.flink.api.connector.sink2#WriterInitContext
Proposed Changes
Properly annotate the above interfaces with the designated annotation.
...
A public interface is any change to the following:
- DataStream and DataSet API, including classes related to that, such as StreamExecutionEnvironment
- Classes marked with the @Public annotation
- On-disk binary formats, such as checkpoints/savepoints
- User-facing scripts/command-line tools, i.e. bin/flink, Yarn scripts, Mesos scripts
- Configuration settings
- Exposed monitoring information
Proposed Changes
Describe the new thing you want to do in appropriate detail. This may be fairly extensive and have large subsections of its own. Or it may be a few sentences. Use judgement based on the scope of the change.
Compatibility, Deprecation, and Migration Plan
- What impact (if any) will there be on existing users?
- If we are changing behavior how will we phase out the older behavior?
- If we need special migration tools, describe them here.
- When will we remove the existing behavior?
Test Plan
Describe in few sentences how the FLIP will be tested. We are mostly interested in system tests (since unit-tests are specific to implementation details). How will we know that the implementation works as expected? How will we know nothing broke?
Rejected Alternatives
- We need to include in the next release notes that these interfaces are deprecated / designated to by annotated as Public
- Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink, org.apache.flink.streaming.api.functions.sink#PrintSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces
Test Plan
Existing tests
Rejected Alternatives
N/AIf there are alternative ways of accomplishing the same thing, what were they? The purpose of this section is to motivate why the design is the way it is and not some other way.