Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Whereas the TestCliDriver tests run all tests under /clientpositive and /clientnegative respectively, the MiniDriver tests (ie, TestMiniTezCliDriver, TestMinimrCliDriver) run only a subset of those for time reasons.  These are determined by a properties file located in ./itests/qtest/testconfiguration.properties.

Currently there are the following properties:

  • minimr.query.files:  Run by TestMinimrCliDriver (positive)

  • minimr.query.negative.files:  Run by TestMinimrCliDriver (negative)

  • minitez.query.files.shared: Run by TestMinimrCliDriver and TestMiniTezCliDriver

  • minitez.query.files: Run by TestMiniTezCliDriver

  • beeline.positive.exclude: Tests excluded when running with TestBeeLineDriver, if its enabled.

Thus, be sure to update this properties file if adding a new MiniDriver test.

As this list may change, check the ./itests/qtest/pom.xml for latest definition of what each does.

The Hive PTest2 Infrastructure running Hive Pre Commit Tests does not use ./itests/qtest/pom.xml but has similar logic to parse this property file, in short because it needs to create different test batches for each node.  If changing these definitions, please keep in mind Ptest2 Infra in addition to the pom.xml would need to understand the new changes as well

The Hive build (non-ptest2) uses properties (in the pom.xml) to describe which .q files should be run with minimr versus the normal test runner. All of these .q files exist in the same directory. Therefore without parsing the pom.xml (or build.xml before it) PTest2 has no way to identify which tests should be run via minimr.

At present we do not parse the pom.xml to obtain the list and instead maintain a separate list. The fallout is that when a new minimr test is created, it must be added to the properties file for precommit to run it. See Hive PTest2 Infrastructure for the host and path of the properties file to edit.