Versions Compared

Old Version 2

changes.mady.by.user Arvind Prabhakar

Saved on

compared with

New Version 3

changes.mady.by.user Arvind Prabhakar

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Committers can contribute patches on their own but should not commit it them directly. As outlined in the How to Contribute guide, a committer should go through the same exercise of creating the patch, submitting it for review and ensuring that it is attached to the JIRA.

...

The only exception to this is when other committers are not available and you are the only active committer. In which case, Sqoop's voted policy is to wait for 2+3 days before committing. The full stated policy is as follows:

...

Wiki Markup

...

Subject:	\[VOTE\]\[RESULT\] Review and Commit Policy	
From:	Arvind Prabhakar (arv...@apache.org)
Date:	Aug 22, 2011 9:53:34 am
List:	org.apache.incubator.sqoop-dev
The vote for Review and Commit Policy is now closed. The proposal voted for is:

...

—
  • The committer attaches the patch s/he 
...
  •  would 
...
  •  like 
...
  •  to 
...
  •  submit 
...
  •  to 
...
  •  the
...

  •  JIRA 
...
  •  and 
...
  •  posts 
...
  •  a 
...
  •  code 
...
  •  review 
...
  •  requests 
...
  •  with 
...
  •  at 
...
  •  least 
...
  •  one 
...
  •  other
...

  •  committer 
...
  •  identified 
...
  •  as 
...
  •  the 
...
  •  reviewer.
...
  • If 
...
  •  the 
...
  •  reviewer 
...
  •  does 
...
  •  not 
...
  •  respond 
...
  •  in 
...
  •  two 
...
  •  days 
...
  •  time, 
...
  •  the 
...
  •  committer
...

  •  sends 
...
  •  a 
...
  •  note 
...
  •  to 
...
  •  sqoop-dev@ 
...
  •  asking 
...
  •  for 
...
  •  the 
...
  •  reviewer 
...
  •  to 
...
  •  prioritize 
...
  •  the
...

  •  review 
...
  •  or 
...
  •  for 
...
  •  any 
...
  •  other 
...
  •  committer 
...
  •  to 
...
  •  volunteer 
...
  •  for 
...
  •  the 
...
  •  review.
...
  • If 
...
  •  the 
...
  •  review 
...
  •  is 
...
  •  still 
...
  •  not 
...
  •  done 
...
  •  in 
...
  •  the 
...
  •  next 
...
  •  three 
...
  •  days, 
...
  •  the 
...
  •  change
...

  •  may 
...
  •  be 
...
  •  committed 
...
  •  and 
...
  •  the 
...
  •  JIRA 
...
  •  resolved/closed.
...
  • If 
...
  •  the 
...
  •  review 
...
  •  is 
...
  •  started, 
...
  •  then 
...
  •  no 
...
  •  timeout 
...
  •  applies 
...
  •  and 
...
  •  the 
...
  •  full
...

  •  review 
...
  •  cycle 
...
  •  should 
...
  •  be 
...
  •  followed 
...
  •  until 
...
  •  a 
...
  •  reasonable 
...
  •  version 
...
  •  of 
...
  •  the
...

  •  change 
...
  •  has 
...
  •  been 
...
  •  accepted. 
...
  •  At 
...
  •  which 
...
  •  point 
...
  •  it 
...
  •  can 
...
  •  be 
...
  •  committed 
...
  •  and 
...
  •  the
...

  •  JIRA 
...
  •  resolved/closed.
...
 Wiki Markup
The DISCUSSION thread for this topic can be found at \[1\].
The VOTE thread for this topic can be found at \[2\].
---
...
Result:
...
The 
...
 proposal 
...
 passes 
...
 with 
...
 the 
...
 following 
...
 votes:
...
3 
...
 +1 
...
 votes: 
...
 Ahmed, 
...
 Mohammad, 
...
 Jonathan
...

 0 
...
 +0 
...
 votes
...

 0 
...
 -1 
...
votes
 Wiki Markup
Relevant threads:
\[1\] http://markmail.org/thread/otolffxxr2b5sdqx
\[2\] http://markmail.org/thread/cmgoaqziyubl4xcg
...
Thanks,
...

 Arvind
...
 Code Block
Source: Original Mail