This page describes a proposed Gobblin Improvement Proposal (GIP) process for proposing a major change to Gobblin.
To create your own GIP, click on "Create" on the header and choose "GIP-Template" other than "Blank page". If you don't have permission, please send an email with your Wiki ID to dev@gobblin.incubator.apache.org
and request permission (https://gobblin.apache.org/mailing-lists). Also add an entry to the table "GIPs under discussion".
Purpose
We want to make Gobblin a core architectural component for users. We also support a large number of integrations with other tools, systems, and clients. Keeping this kind of usage health requires a high level of compatibility between releases — core architectural elements can't break compatibility or shift functionality from release to release. As a result each new major feature or public api has to be done in a way that we can stick with it going forward.
This means when making this kind of change we need to think through what we are doing as best we can prior to release. And as we go forward we need to stick to our decisions as much as possible. All technical decisions have pros and cons so it is important we capture the thought process that lead to a decision or design to avoid flip-flopping needlessly.
Hopefully we can make these proportional in effort to their magnitude — small changes should just need a couple brief paragraphs, whereas large changes need detailed design discussions.
This process also isn't meant to discourage incompatible changes — proposing an incompatible change is totally legitimate. Sometimes we will have made a mistake and the best path forward is a clean break that cleans things up and gives us a good foundation going forward. Rather this is intended to avoid accidentally introducing half thought-out interfaces and protocols that cause needless heartburn when changed. Likewise the definition of "compatible" is itself squishy: small details like which errors are thrown when are clearly part of the contract but may need to change in some circumstances, likewise performance isn't part of the public contract but dramatic changes may break use cases. So we just need to use good judgement about how big the impact of an incompatibility will be and how big the payoff is.
What is considered a "major change" that needs a GIP?
Any of the following should be considered a major change:
- Any major new feature, subsystem, or piece of functionality
- Any change that impacts the public interfaces of the project
For the most part monitoring, command line tool changes, and configs are added with new features so these can be done with a single GIP.
What should be included in a GIP?
A GIP should contain the following sections:
- Motivation: describe the problem to be solved
- Proposed Change: describe the new thing you want to do. This may be fairly extensive and have large subsections of its own. Or it may be a few sentences, depending on the scope of the change.
- New or Changed Public Interfaces: impact to any of the "compatibility commitments" described above. We want to call these out in particular so everyone thinks about them.
- Migration Plan and Compatibility: if this feature requires additional support for a no-downtime upgrade describe how that will work
- Rejected Alternatives: What are the other alternatives you considered and why are they worse? The goal of this section is to help people understand why this is the best solution now, and also to prevent churn in the future when old alternatives are reconsidered.
Who should initiate the GIP?
Anyone can initiate a GIP but you shouldn't do it unless you have an intention of getting the work done to implement it (otherwise it is silly).
Process
Here is the process for making a GIP:
- Create a page which is a child of this one. Take the next available GIP number and give your proposal a descriptive heading. e.g. "GIP 1: Autoscaling gobblin workers in AWS".
- Fill in the sections as described above
- Start a [DISCUSS] thread on the Apache mailing list. Please ensure that the subject of the thread is of the format [DISCUSS] GIP-{your GIP number} {your GIP heading} The discussion should happen on the mailing list not on the wiki since the wiki comment system doesn't work well for larger discussions. In the process of the discussion you may update the proposal. You should let people know the changes you are making. When you feel you have a finalized proposal
- Once the proposal is finalized call a [VOTE] to have the proposal adopted. These proposals are more serious than code changes and more serious even than release votes. The criteria for acceptance is lazy majority.
- Please update the GIP wiki page, and the index below, to reflect the current stage of the GIP after a vote. This acts as the permanent record indicating the result of the GIP (e.g., Accepted or Rejected). Also report the result of the GIP vote to the voting thread on the mailing list so the conclusion is clear.
GIP round-up
Next GIP Number: 2
Use this number as the identifier for your GIP and increment this value.
Adopted GIPs
GIP | Release |
---|---|
GIPs under discussion
GIP | Comment |
---|---|
Dormant/inactive GIPs
GIP | Comment |
---|---|
Discarded GIPs
GIP | Comment |
---|---|