DRAFT: How to Release

Introduction

From time to time, Impala creates releases. These are tarballs of the Impala source that follow the rules below.

Decisions about releases are made by four groups:

A Release Manager, who must be a committer, does the work of creating the release, signing it, counting votes, and so on.
The community, who share in the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release.
The PMC, who cast binding votes on the release.
The Incubator PMC, who must approve all Impala releases until Impala graduates to an Apache Top Level Project.

This page describes the procedures that the release manager and voting PMC members take during release time.

How to Manage a Release

Release managers are self-selected from among the set of committers. Release management must happen partially on "hardware owned and controlled by the committer". In particular, release managers are not permitted to store code signing keys on hardware they do not own or control.

If you have not done so yet, set up your apache.org email address.
Make a code signing key if you don't have one yet
1. Publish your key if you haven't done so yet
If you haven't done so yet, add yourself to the Apache Web-of-Trust by meeting face-to-face with a person so they can sign your key
1. Publish your signed key
If you haven't done so before, add your key to the KEYS file in the release staging area and the release distribution area
1. The staging area is https://dist.apache.org/repos/dist/dev/incubator/impala/. Once graduated, it will presumably be https://dist.apache.org/repos/dist/dev/impala/
2. The release area is https://dist.apache.org/repos/dist/release/incubator/impala/, and will presumably be https://dist.apache.org/repos/dist/release/impala/ after graduation.
Pick a commit in the "master" branch you want to release from and test it.
Test the licencing using Apache RAT; follow the instructions in bin/check-rat-report.py.
Propose a release on the dev@ list. It should start with the string "[DISCUSS]". Explain that this is not a "[VOTE]", and that anyone may participate.
Make a new branch off of your commit called "branch-x.y.z", where x.y.z is the version you want to release
1. ```
git checkout $COMMIT_HASH_YOU_CHOSE
git checkout -b branch-x.y.z
git push apache branch-x.y.z 
```
2. In this branch (but not in master) update the version number in bin/save-version.sh to x.y.z-RELEASE

Continue testing. If you find bugs, file them. When they are fixed, cherry-pick the fixes from master to your branch that you want to include in the release

git fetch apache # to make sure you have the latest master
git log apache/master # to find the commits you want to cherry-pick
git checkout apache/branch-x.y.z
git checkout -b x.y.z-patch-foo # the name doesn't matter - it will only be in your local workstation
git cherry-pick b4d1a3... # or whatever git hashes
# then resolve conflicts, if there are any
# cherry-pick some more commits:
git cherry-pick ....
git cherry-pick .....
git push apache HEAD:branch-x.y.z

At that time, tag the tree at the release candidate

git fetch apache
git checkout apache/branch-x.y.z
git tag -a x.y.z-rcw -m "x.y.z release candidate w" # when making release candidate w of version x.y.z
git push apache x.y.z-rcw

Make a release tarball:

Make the tarball using git archive. Name it apache-impala-incubating-x.y.z.tar.gz, or apache-impala-x.y.z.tar.gz if Impala has graduated from the incubator.
```
git archive --prefix=apache-impala-incubating-x.y.z/ -o /tmp/apache-impala-incubating-x.y.z.tar.gz x.y.z-rcw
```

Make signature, as well as md5 and sha1 checksums. This must be done on "hardware owned and controlled by the committer".

# Make the signature:
gpg -u YOUR_APACHE_USER_NAME@apache.org --armor --output apache-impala-incubating-x.y.z.tar.gz.asc --detach-sign apache-impala-incubating-x.y.z.tar.gz
 
# Make sure it worked:
gpg --verify apache-impala-incubating-x.y.z.tar.gz.asc
 
# Make checksums:
md5sum apache-impala-incubating-x.y.z.tar.gz > apache-impala-incubating-x.y.z.tar.gz.md5
sha1sum apache-impala-incubating-x.y.z.tar.gz > apache-impala-incubating-x.y.z.tar.gz.sha
 
# Make sure they worked:
md5sum --check apache-impala-incubating-x.y.z.tar.gz.md5
sha1sum --check apache-impala-incubating-x.y.z.tar.gz.sha

Before uploading your release candidate, follow the procedure in the section below on how to vote on a release. Don't upload until you could vote +1.
Get commitments from at least five PMC members to vote on the artifact in the time frame for the upcoming vote. While we are incubating, the list of PMC members is at http://incubator.apache.org/projects/impala.html. Once Impala graduates, that list will presumably be available at http://people.apache.org/committers-by-project.html#impala-pmc.

Upload the artifacts. While incubating, the location is https://dist.apache.org/repos/dist/dev/incubator/impala/. Once graduated, it will presumably be https://dist.apache.org/repos/dist/dev/impala/. Upload all four artifacts. Do not overwrite old release candidates.

svn checkout https://dist.apache.org/repos/dist/dev/incubator/impala/
cd impala/
# The directory layout is x.y.z/RCw, where w is the release candidate number - RC1 is the first candidate, RC2 the second, and so on.
mkdir -p x.y.z/RCw
cd x.y.z/RCw
cp /tmp/apache-impala-incubating-x.y.z.tar.gz* ./
svn add .
svn commit --username=YOUR_APACHE_USER_NAME -m "Impala x.y.z release candidate w"

Prepare a patch to the downloads.html page (on the asf-site branch of the git repo) to point to the latest downloads. Do not submit it yet.
Take a vote on dev@. Your vote email should:
1. Have a subject that starts with "[VOTE]"
2. Explain what the vote is about
3. Explain how to find the artifacts for testing, and include the tag and git tree hash (not release hash!) they correspond to. The tree hash can be viewed with git log --pretty="%T %s".
4. Explain what each type of vote means
5. Explain the conditions for the vote passing, including how long the vote will remain open for.
6. Include a link to this wiki page so voters can read the instructions in it on how to test, verify, and vote.
7. Explain how you tested it.
8. At your discretion, discuss what dependencies or tools you used to compile or run it, like gcc, hadoop, impala-lzo, and so on.
9. Be consistent with the Impala bylaws. For instance, at the moment I am writing this wiki page, votes stay open for 72 hours (not counting weekends), and only PPMC members (and mentors) have binding votes.
When the vote closes, tally up the votes (who votes what) in a thread with the same title as the vote thread, but with "[RESULT] " prepended. That email should include a list of every vote, and reasons for the -1s ala:
```
+1 (binding):
 
Alice Bobopolis
Carol Davestein
 
-1 (non-binding):
 
Emily Frankfurt (Build failed)
```
If the vote passes, and Impala has yet to graduate, take a vote in the incubator PMC, following current incubator policy.
1. Subscribe to general@incubator.apache.org by sending mail to general-subscribe@ and responding to the email it sends back.
2. Send an email to that list including:
  1. Subject "[VOTE] Impala x.y.z release candidate w"
  2. A link to the archive of the proposal thread from the dev@impala mailing list, available either http://mail-archives.apache.org/mod_mbox/impala-dev/ or https://lists.apache.org/list.html?dev@impala.apache.org
  3. A link to the archive of the [RESULT] of the vote from the dev@impala mailing list.
  4. A link to the artifacts for testing
  5. A link to the KEYS file with the signatures
  6. A link to the git tag the release candidate tarball was created from
  7. The hash of the git commit the release candidate tarball was created from
  8. Instructions on using RAT on our code.
  9. Build instructions.
  10. A list of the IPMC members who have already +1ed. For instance, as of 28 September 2016, all of our mentors are IPMC members, so their +1s are good for either vote - the one with the PPMC or the one with the IPMC.
  11. ```
  This vote will be open for at least 72 hours, or until the necessary
  number of votes (3 +1) is reached.
  
  [ ] +1 Approve the release
  [ ] -1 Don't approve the release (please provide specific comments)
```
Like with the dev@ vote, post a "[RESULT]" thread to general@ with the results.

Once that vote passes, tag the git tree at the release:

git fetch apache
git checkout apache/branch-x.y.z
git tag -a x.y.z m "x.y.z release"
git push apache x.y.z

Publish the release. While incubating, the location is https://dist.apache.org/repos/dist/release/incubator/impala/. Once graduated, it will presumably be https://dist.apache.org/repos/dist/release/impala/. Upload all four artifacts.

svn checkout https://dist.apache.org/repos/dist/release/incubator/impala/
cd impala/
mkdir x.y.z
cd x.y.z
cp /tmp/apache-impala-incubating-x.y.z.tar.gz* ./
svn add .
svn commit --username=YOUR_APACHE_USER_NAME
# You will be prompted to write a commit message. Make it look like (without the '#'s):
#
# Impala release x.y.z
# 
# PPMC vote thread: ...
#
# PPMC vote results thread: ...
#
# IPMC vote thread: ...
#
# IMPC vote results thread: ...

Wait 24 hours for mirrors to catch up.
Push your patch to the downloads.html page.
In the bug tracker, change the target version for bugs targeted at x.y.z to a future release number.

Announce the release to dev@impala.apache.org, user@impala.apache.org, and announce@apache.org. The email must come from your apache.org email address.

If you are not already subscribed from your @apache.org address, subscribe to dev@ and user@ by mailing dev-subscribe@ and user-subscribe@.

Give your email a subject like "[ANNOUNCE] Apache Impala (incubating) x.y.z release", and include in the body:

The Apache Impala (incubating) team is pleased to announce the release of Impala x.y.z.
 
Impala is a high-performance C++ and Java SQL query engine for data stored in Apache
Hadoop-based clusters.
 
The release is available at: https://impala.incubator.apache.org/downloads.html
 
Thanks,
 
The Apache Impala (incubating) team
 
=====
 
*Disclaimer*
 
Apache Impala is an effort undergoing incubation at The Apache Software Foundation (ASF),
sponsored by the name of Apache Incubator PMC. Incubation is required of all newly accepted
projects until a further review indicates that the infrastructure, communications, and
decision making process have stabilized in a manner consistent with other successful ASF
projects. While incubation status is not necessarily a reflection of the completeness or
stability of the code, it does indicate that the project has yet to be fully endorsed by
the ASF.

Announce the release on the community links listed on https://impala.apache.org/community.html.
Send a patch review to the master branch to update its version number to "p.q.r-SNAPSHOT" (where p.q.r is greater than x.y.z)

How to Vote on a Release Candidate

Download the tarball. Check the signature and the checksums, and check that the tarball matches the upstream tag. The script below shows how to do each of those steps. To use it, set your environment variables VERSION, RELEASE_CANDIDATE, and TREE_HASH, like:

VERSION=2.8.0 RELEASE_CANDIDATE=1 TREE_HASH=cc8de358d5c64778d171ad47aa6b513d437ac4b0 ./release.sh

Committers can run this (along with the pre-commit tests) via the experimental "release-test" job on Impala's Jenkins server.

#!/bin/bash

set -euxo pipefail

echo "Set up a sandbox for key import and a temporary directory for git"
export GNUPGHOME="$(mktemp -d)"
IMPALA_GIT="$(mktemp -d)"

echo "Delete gpg sandbox and temporary directory when done"
function onexit {
  rm -rf "${GNUPGHOME}"
  rm -rf "${IMPALA_GIT}"
  df -m
  free -m
  uptime -p
}
trap onexit EXIT

pushd "${GNUPGHOME}"

echo "Download the keys of the release managers:"

wget https://dist.apache.org/repos/dist/dev/incubator/impala/KEYS

gpg --import KEYS

echo "If in an interactive shell, At the prompt, enter '5' for 'I trust ultimately', then 'y' for 'yes', then 'q' for 'quit'"
if [[ $- == *i* ]]; then
  gpg --edit-key APACHE_USER_NAME_OF_RELEASE_MANAGER trust
fi
  
echo "Download the release artifacts:"
for SUFFIX in gz gz.asc gz.md5 gz.sha; do
  wget -q "https://dist.apache.org/repos/dist/dev/incubator/impala/${VERSION}/RC${RELEASE_CANDIDATE}/apache-impala-incubating-${VERSION}.tar.${SUFFIX}"
done

echo "Check the checksums:"
md5sum --check "apache-impala-incubating-${VERSION}.tar.gz.md5"
sha1sum --check "apache-impala-incubating-${VERSION}.tar.gz.sha"
 
echo "Check the signature:"
gpg --verify "apache-impala-incubating-${VERSION}.tar.gz.asc"

echo "Download git to make sure the tarball, git tag, and tree hash all correspond:"
pushd "${IMPALA_GIT}"
sudo apt-get -q=2 update
sudo apt-get -q=2 install git
git clone https://git-wip-us.apache.org/repos/asf/incubator-impala.git
cd *
git checkout "${VERSION}-rc${RELEASE_CANDIDATE}"

echo "Check the tree hash from the release manager is correct:"
if ! (git rev-list --pretty=format:"%T" --max-count=1 HEAD | grep "${TREE_HASH}"); then
  echo "Tree hash ${TREE_HASH} not found"
  exit 1
fi

echo "Remove the .git directory to make tarball and git directories equal:"
rm -rf .git
IMPALA_GIT="$(pwd)"
popd
 
echo "Compare the tarball and the repo:"
tar xzf "apache-impala-incubating-${VERSION}.tar.gz"
diff -r "apache-impala-incubating-${VERSION}" "${IMPALA_GIT}"

Test the release quality, possibly using bin/run-all-tests.py. The ASF requires in its "Release Policy" that: "Before voting +1 PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." The ASF interprets "own platform" in this sentence to not require that you own and physically control the machine you are testing on, unlike the procedure for signing a release.
Check compliance with ASF release policy. Use Apache RAT and follow the instructions in bin/check-rat-report.py to check licence compliance.
If it is an official "[VOTE]" thread, vote +1 or -1. If you are a PMC member, add "(binding)" after your vote; otherwise, add "(non-binding)". If you vote -1, explain why.

Space shortcuts

Page tree

Introduction

How to Manage a Release

How to Vote on a Release Candidate