...
If you are an Eclipse user, you can apply a patch by : 1. Right click project name in Package Explorer , 2. Team -> Apply Patch
Review Process
Note: we are currently testing out Phabricator as an alternative to Review Board, so you can use either system for now.
If your patch contains more than 2 files that are changed and not yet had a review, please submit to Review Board. Some helpful hints for Review Board:
...
- If you're using Git instead of svn, you will need to select the
hive-git
repository.
...
- This ensures that Review Board will send a notification email to the hive-dev list.
...
See Phabricator for instructions.
- Use Hadoop's code review checklist as a rough guide when doing reviews
- Reviewers can approve the patch by clicking on the "Ship it" option.
- In JIRA, use Submit Patch to get your review request into the queue.
- If a committer requests changesShould your patch earn a -1 review, set the issue status to 'Resume Progress', upload a patch to Review Board with necessary fixes and then set the status to with 'Submit Patch' again.
...
- Once your patch is accepted, be sure to upload a final version which grants rights to the ASF.
Contributing your work
Finally, patches should be attached to an issue report in JIRA via the Attach File link on the issue's JIRA. Please add a comment that asks for a code review. Please note that the attachment should be granted license to ASF for inclusion in ASF works (as per the Apache License).
...