...
After you have committed a change or set of changes to your local repository, you need to create a patch to post on the JIRA. The The naming convention for patches is:
| Code Block |
|---|
HIVE-<JIRA-NUMBER>[.<patch-num>][-<branch-name>].patch |
<patch-num> is only required if it is not the first patch.
<branch-name> is only required if it is not master.
So the first patch for JIRA HIVE-9999 intended to be applied to master would be named "HIVE-9999.patch".
The second patch for the same JIRA would be named "HIVE-9999.2.patch".
A patch for the same JIRA intended to be applied to the llap branch would be named HIVE-9999-llap.patch".
| Code Block |
|---|
git diff --no-prefix <commit> > HIVE-1234.1.patch |
<commit> is the last commit from Hive (not you) before your commits. Note Note that if it has been a while since you fetched or pulled from the Hive repository, you may need to do a rebase to get you your commit(s) on top in order to create a patch that will cleanly apply.
...
- reformat code unrelated to the bug being fixed: formatting changes should be separate patches/commits.;
- comment out code that is now obsolete: just remove it.;
- insert comments around each change, marking the change: folks can use subversion to figure out what's changed and by whom.;
- make things public which are not required by end users.
...
- try to adhere to the coding style of files you edit;
- comment code whose function or rationale is not obvious;
- update documentation (e.g., package.html files, hive-default.xml.template, this wiki, etcand so on).)
Attaching and Submitting a Patch
...