Page History

...

Get the source code on your local drive using git. See Understanding Hive Branches 83527164 below to understand which branch you should be using.

...

•  Create an Apache Software Foundation JIRA account if you do not already have one: Sign Up for JIRA.
  • The ASF JIRA system dashboard is here.
  • The Hive JIRA is here. 
•  To review patches for JIRA tickets, use the Review Board. If you need an account, register here. See Review Process83527164 below for more information.
  • All Hive patches posted for review are listed here.
  • Individual JIRA tickets provide a link to the issue on the review board when a review request has been made.
  • For simple reviews, you can just read the patch attached to the JIRA ticket and post a comment.
•  To contribute to the Hive wiki, follow the instructions in About This Wiki.
•  To edit the Hive website, follow the instructions in How to edit the website.
•  Join the Hive mailing lists to receive email about issues and discussions.

...

<branch-name> is only required if it is not master. (See Understanding Hive Branches 83527164 above.)

So the first patch for JIRA HIVE-9999 intended to be applied to master would be named "HIVE-9999.patch".

...

• try to adhere to the coding style of files you edit;
• comment code whose function or rationale is not obvious;
• add one or more unit tests (see Add a Unit Test 83527164 above);
• update documentation (such as Javadocs including package.html files and this wiki).

...

If the name of your patch conforms to the naming convention shown above, the automated testing system will run precommit tests and post the results as a JIRA comment from Hive QA. The results give advisory +1 or -1 votes (SUCCESS or ERROR) based on whether all of the tests executed successfully and, more recently, whether existing tests are modified or new tests are included in the patch to cover the code changes. For examples, see the Hive QA comments on HIVE-9534 and HIVE-11752. Note that sometimes tests fail for reasons unrelated to the patch.

...

This section only gives the basic procedures for attaching and submitting a patch. See Contributing Your Work 83527164 below for more information.

...

1. Don't make any changes to hive_metastore.thrift until instructed below.
2. Use the approved version of Thrift. This is currently thrift-0.9.3, which you can obtain from http://thrift.apache.org/. (Or on Mac: brew install thrift@0.9, and no need to build, skip to step 4.)
3. Build the Thrift compiler from its sources, then install it:
   1. cd /path/to/thrift-0.9.3
   2. ./configure --without-csharp --without-ruby
   3. make
   4. sudo make install
4. Before proceeding, verify that which thrift returns the build of Thrift you just installed (typically /usr/local/bin on Linux); if not, edit your PATH and repeat the verification. Also verify that the command 'thrift -version' returns the expected version number of Thrift.
5. Now you can run the Maven 'thriftif' profile to generate the Thrift code:
   1. cd /path/to/hive-trunk/

   2. mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local  -Phadoop-2

   3. If you see an error about fb303.thrift not being found, copy it to the appropriate directory and run above command again.
      • On centOS/RHEL:
        cp /path/to/thrift-0.9.3/contrib/fb303/if/fb303.thrift /usr/local/share/fb303/if/fb303.thrift
      • On Mac with homebrew:
        $ cd /usr/local/Cellar/thrift@0.9/0.9.3 && mkdir -p share/fb303/if && cd share/fb303/if && curl -o fb303.thrift  https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift
6. Verify that the code generation was a no-op, which should be the case if you have the correct Thrift version and everyone has been following these instructions. You may use git status or svn status for the same. If you can't figure out what is going wrong, ask for help from a committer.
7. Now make your changes to hive_metastore.thrift, and then run the compiler again, from /path/to/hive-trunk/<hive_metastore.thrift's module>:

   1. mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local  -Phadoop-2

8. Now use svn status and svn diff or git status and git diff to verify that the regenerated code corresponds only to the changes you made to hive_metastore.thrift. You may also need svn add or git add if new files were generated (and svn remove or git rm if files have been obsoleted).
9. cd /path/to/hive-trunk
10. ant clean package
11. Verify that Hive is still working correctly with both embedded and remote metastore configurations.

...

• Apache contributor documentation
• Apache voting documentation
• How to edit the website

...