Page History

...

This checklist tells you how to create accounts and obtain permissions needed by Hive contributors. See the Hive website for additional information.

•  Create Request an Apache Software Foundation JIRA account, if you do not already have one: Sign Up for JIRA.
  • The ASF JIRA system dashboard is here.
  • The Hive JIRA is here. 
•  To review patches you could do that on Github
  • All Hive patches posted for review are listed here.
  • Individual JIRA tickets provide a link to the issue on the review board when a review request has been made.
•  To contribute to the Hive wiki, follow the instructions in About This Wiki.
•  To edit the Hive website, follow the instructions in How to edit the website.
•  Join the Hive mailing lists to receive email about issues and discussions.

Making Changes

If you're a newcomer, feel free to contribute by working on a newbie task.

Before you start, send a message to the Hive developer mailing list, or file a bug report in JIRA. Describe your proposed changes and check that they fit in with what others are doing and have planned for the project. Be patient, it may take folks a while to understand your requirements.

...

Committers: for non-trivial changes, it is best to get another committer to review your patches before commit. Use the Submit Patch link like other contributors, and then wait for a "+1" from another committer before committing. Please also try to frequently review things in the patch queue.

JIRA

...

Hive uses JIRA for issues/case management. You must If you don't already have a JIRA account , sign Up for JIRA.in order to log cases and issues.

Requests for the creation of new accounts can be submitted via the following form: https://selfserve.apache.org/jira-account.html

Guidelines

Please comment on issues in JIRA, Please comment on issues in JIRA, making your concerns known. Please also vote for issues that are a high priority for you.

...

Please leave Fix Version/s empty when creating the issue – it should not be tagged until an issue is closed, and then, it is tagged by the committer closing it to indicate the earliest version(s) the fix went into. Instead of Fix Version/s, use Target Version/s to request which versions the new issue's patch should go into. (Target Version/s was added to the Create Issue form in November 2015. You can add target versions to issues created before that with the Edit button, which is in the upper left corner.)target versions to issues created before that with the Edit button, which is in the upper left corner.)

Consider using bi-directional links when referring to other tickets. It is very common and convenient to refer to other tickets by adding the HIVE-XXXXX pattern in summary, description, and comments. The pattern allows someone to navigate quickly to an older JIRA from the current one but not the other way around. Ideally, along with the mention (HIVE-XXXXX) pattern, it helps to add an explicit link (relates to, causes, depends upon, etc.) so that the relationship between tickets is visible from both ends.

Add the "backward-incompatible" label to tickets changing the behavior of some component or introduce modifications to public APIs. There are various other labels available for similar purposes but this is the most widely used across projects so it is better to stick to it to keep things uniform.

When in doubt about how to fill in the Create Issue form, take a look at what was done for other issues.  Here Here are several Hive JIRA issues that you can use as examples:

...

1. Don't make any changes to hive_metastore.thrift until instructed below.
2. Use the approved version of Thrift. This is currently thrift-0.14.1, which you can obtain from http://thrift.apache.org/.

   1. For Mac via Homebrew (since the version we need is not available by default):

      Code Block
      language bash
      brew tap-new $USER/local-tap brew extract --version='0.14.1' thrift $USER/local-tap brew install thrift@0.14.1 mkdir -p /usr/local/share/fb303/if cp /usr/local/Cellar/thrift@0.14.1/0.14.1/share/fb303/if/fb303.thrift /usr/local/share/fb303/if

      
      

   2. For Mac, building from sources:

      Code Block
      language bash
      wget http://archive.apache.org/dist/thrift/0.14.1/thrift-0.14.1.tar.gz tar xzf thrift-0.14.1.tar.gz #If configure fails with "syntax error near unexpected token `QT5", then run "brew install pkg-config" ./bootstrap.sh sudo ./configure --with-openssl=/usr/local/Cellar/openssl@1.1/1.1.1j --without-erlang --without-nodejs --without-python --without-py3 --without-perl --without-php --without-php_extension --without-ruby --without-haskell --without-go --without-swift --without-dotnetcore --without-qt5 brew install openssl sudo ln -s /usr/local/opt/openssl/include/openssl/ /usr/local/include/ sudo make sudo make install mkdir -p /usr/local/share/fb303/if cp path/to/thrift-0.14.1/contrib/fb303/if/fb303.thrift /usr/local/share/fb303/if/fb303.thrift # or alternatively the following command curl -o /usr/local/share/fb303/if/fb303.thrift https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift

      
      

   3. For Linux:

      Code Block
      language bash
      cd /path/to/thrift-0.14.1 /configure -without-erlang --without-nodejs --without-python --without-py3 --without-perl --without-php --without-php_extension --without-ruby --without-haskell --without-go --without-swift --without-dotnetcore --without-qt5 sudo make sudo make install sudo mkdir -p /usr/local/share/fb303/if sudo cp /path/to/thrift-0.14.1/contrib/fb303/if/fb303.thrift /usr/local/share/fb303/if/fb303.thrift

      
      

3. Before proceeding, verify that which thrift returns the build of Thrift you just installed (typically /usr/local/bin on Linux); if not, edit your PATH and repeat the verification. Also verify that the command 'thrift -version' returns the expected version number of Thrift.

4. Now you can run the Maven 'thriftif' profile to generate the Thrift code:
   1. cd /path/to/hive/

   2. mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local

5. Verify that the code generation was a no-op, which should be the case if you have the correct Thrift version and everyone has been following these instructions. You may use git status for the same. If you can't figure out what is going wrong, ask for help from a committer.
6. Now make your changes to hive_metastore.thrift, and then run the compiler again, from /path/to/hive/<hive_metastore.thrift's module>:

   1. mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local

7. Now use git status and git diff to verify that the regenerated code corresponds only to the changes you made to hive_metastore.thrift. You may also need git add if new files were generated (and or git rm if some files are now obsoleted).
8. cd /path/to/hive
9. mvn clean package -DskiptTests (at the time of writing also "-Dmaven.javadoc.skip" is needed)
10. Verify that Hive is still working correctly with both embedded and remote metastore configurations.

...

Contributors should join the Hive mailing lists. In particular the dev list (to join discussions of changes) and the user list (to help others).

...